| Summary: | [css-grid] Apply content alignment to row estimation in step 1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zsun | ||||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, changseok, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, sgill26, svillar, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar, WPTImpact | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | http://wpt.live/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zsun
2021-11-03 07:29:06 PDT
Created attachment 443199 [details]
Patch
Created attachment 443684 [details]
Patch
Created attachment 448768 [details]
Patch
Comment on attachment 448768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448768&action=review > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1196 > + if ((rawTrackSize.minTrackBreadth().isLength() && rawTrackSize.minTrackBreadth().length().isSpecified()) && rawTrackSize.hasFixedMaxTrackBreadth() && rawTrackSize.minTrackBreadth().length() == rawTrackSize.maxTrackBreadth().length()) Seems like we should have a way to do == on two GridLength without calling length() twice. Affected test css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html The submitted patch doesn't seem fixing the test failure. It seems passing with this patch in my local(GTK) run though. Please feel free to take this bug as I can't foresee that I would have time on it in a short while. |