Bug 232667

Summary: [css-grid] Apply content alignment to row estimation in step 1
Product: WebKit Reporter: zsun
Component: Layout and RenderingAssignee: Sammy Gill <sgill26>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, sgill26, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar, WPTImpact
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://wpt.live/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

zsun
Reported 2021-11-03 07:29:06 PDT
... when all rows have a definite max track sizing function, and the container has a definite block-size.
Attachments
Patch (5.88 KB, patch)
2021-11-03 07:43 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (5.88 KB, patch)
2021-11-09 05:38 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (6.01 KB, text/plain)
2022-01-10 10:24 PST, zsun 		ews-feeder: commit-queue-
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2021-11-03 07:43:39 PDT
Created attachment 443199 [details] Patch
zsun
Comment 2 2021-11-09 05:38:03 PST
Created attachment 443684 [details] Patch
Radar WebKit Bug Importer
Comment 3 2021-11-10 06:30:23 PST
<rdar://problem/85252183>
zsun
Comment 4 2022-01-10 10:24:44 PST
Created attachment 448768 [details] Patch
Darin Adler
Comment 5 2022-01-10 14:34:11 PST
Comment on attachment 448768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448768&action=review > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1196 > + if ((rawTrackSize.minTrackBreadth().isLength() && rawTrackSize.minTrackBreadth().length().isSpecified()) && rawTrackSize.hasFixedMaxTrackBreadth() && rawTrackSize.minTrackBreadth().length() == rawTrackSize.maxTrackBreadth().length()) Seems like we should have a way to do == on two GridLength without calling length() twice.
zsun
Comment 6 2022-05-13 03:07:07 PDT
Affected test css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html The submitted patch doesn't seem fixing the test failure. It seems passing with this patch in my local(GTK) run though. Please feel free to take this bug as I can't foresee that I would have time on it in a short while.
Sammy Gill
Comment 7 2025-06-04 12:00:27 PDT
*** Bug 260597 has been marked as a duplicate of this bug. ***
Sammy Gill
Comment 8 2025-06-04 13:49:32 PDT
Pull request: https://github.com/WebKit/WebKit/pull/46339
EWS
Comment 9 2025-06-16 23:15:53 PDT
Committed 296300@main (c3dbdf3e5964): <https://commits.webkit.org/296300@main> Reviewed commits have been landed. Closing PR #46339 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.