Bug 232665

Summary: ::slotted element style not invalidated correctly in nested case
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Antti Koivisto 2021-11-03 06:02:34 PDT
If an element is slotted through multiple slots its style may not get invalidated correctly.
Comment 1 Antti Koivisto 2021-11-03 06:51:07 PDT
Created attachment 443196 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-11-03 09:07:22 PDT
Comment on attachment 443196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443196&action=review

> Source/WebCore/ChangeLog:8
> +        We fail to invalidae ::slotted style if the assinged node is not from the current host scope.

assinged

> Source/WebCore/ChangeLog:13
> +        Invalidate by following assinged node chain recursively instead of just dumbly invalidating all host children.

assinged. Please use a more inclusive term than "dumbly"
Comment 3 Antti Koivisto 2021-11-03 09:25:35 PDT
Created attachment 443203 [details]
Patch for landing
Comment 4 EWS 2021-11-03 09:59:56 PDT
Committed r285211 (243837@main): <https://commits.webkit.org/243837@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443203 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-03 10:00:24 PDT
<rdar://problem/84979096>