Bug 232646 – Make scroll elasticity an enum class

• Component: New Bugs
• Status: RESOLVED FIXED

[Nikos Mouchtaris]

Make scroll elasticity an enum class

[Nikos Mouchtaris]

Created attachment 443147 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 443147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443147&action=review

> Source/WebCore/page/FrameView.cpp:200
> +    ScrollElasticity verticalElasticity = ScrollElasticity::None;
> +    ScrollElasticity horizontalElasticity = ScrollElasticity::None;

You could use 'auto' here since it's now very obvious from the RHS what the values are.

> Source/WebCore/page/Page.cpp:285
> +    , m_verticalScrollElasticity(ScrollElasticity::Allowed)
> +    , m_horizontalScrollElasticity(ScrollElasticity::Allowed)

No need for this since you have the initializers.

> Source/WebCore/page/Page.h:1043
> -    unsigned m_verticalScrollElasticity : 2; // ScrollElasticity
> -    unsigned m_horizontalScrollElasticity : 2; // ScrollElasticity    
> +    ScrollElasticity m_verticalScrollElasticity { ScrollElasticity::Allowed };
> +    ScrollElasticity m_horizontalScrollElasticity { ScrollElasticity::Allowed };

You've undone some memory saving bitfield stuff here; you'll now use 2 bytes instead of one. But since there are not many Page objects allocated, that's probably OK.

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:390
> +    ts.dumpProperty("horizontal scroll elasticity", static_cast<int>(scrollableAreaParameters.horizontalScrollElasticity));

The ideal way to fix this would be to implement TextStream& operator<<(TextStream& ts, ScrollElasticity)

[Nikos Mouchtaris]

Created attachment 443253 [details]
Patch

[Nikos Mouchtaris]

Created attachment 443264 [details]
Patch

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 443264 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Nikos Mouchtaris]

Created attachment 443356 [details]
Patch

[Nikos Mouchtaris]

Created attachment 443366 [details]
Patch

[EWS]

Committed r285347 (243908@main): <https://commits.webkit.org/243908@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443366 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85079767>