Bug 232639

Summary: [WebIDL] convertVariadicArguments() should return a FixedVector
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: BindingsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: benjamin, berto, cdumez, cgarcia, changseok, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gustavo, gyuyoung.kim, hta, jer.noble, kangil.han, macpherson, menard, philipj, sergio, tommyw, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Alexey Shvayka 2021-11-02 14:42:41 PDT 
[WebIDL] convertVariadicArguments() should return a FixedVector
Comment 1 Alexey Shvayka 2021-11-02 14:45:18 PDT 
Created attachment 443136 [details]
Patch
Comment 2 Yusuke Suzuki 2021-11-02 15:00:23 PDT 
Comment on attachment 443136 [details]
Patch

r=me
Comment 3 Alexey Shvayka 2021-11-02 16:40:29 PDT 
Created attachment 443145 [details]
Patch

Make the change for deprecated document.createTouchList() as well.
Comment 4 Alexey Shvayka 2021-11-03 02:14:31 PDT 
Created attachment 443181 [details]
Patch

Add missing FixedVector imports.
Comment 5 Alexey Shvayka 2021-11-04 16:01:17 PDT 
Created attachment 443350 [details]
Patch

Add some more FixedVector imports.
Comment 6 Radar WebKit Bug Importer 2021-12-09 13:16:41 PST 
<rdar://problem/86287565>
Comment 7 Alexey Shvayka 2021-12-17 15:28:34 PST 
Created attachment 447484 [details]
Patch

Add / remove tokens in WebKitDOMDOMTokenList one-by-one.
Comment 8 EWS Watchlist 2021-12-17 15:29:29 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 9 Alexey Shvayka 2021-12-18 08:03:35 PST 
Comment on attachment 447484 [details]
Patch

(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 443136 [details]
> Patch
> 
> r=me

Thanks for review, Yusuke!
Comment 10 EWS 2021-12-18 08:59:31 PST 
Patch 447484 does not build
Comment 11 Alexey Shvayka 2021-12-18 09:39:59 PST 
Created attachment 447522 [details]
Patch for landing
Comment 12 Alexey Shvayka 2021-12-18 09:40:18 PST 
(In reply to Alexey Shvayka from comment #11)
> Created attachment 447522 [details]
> Patch for landing

Rebase on top of r287220.
Comment 13 EWS 2021-12-18 11:43:07 PST 
Found 1 new test failure: http/wpt/push-api/pushEvent.any.serviceworker.html
Comment 14 Alexey Shvayka 2021-12-20 17:52:26 PST 
Comment on attachment 447522 [details]
Patch for landing

(In reply to EWS from comment #13)
> Found 1 new test failure: http/wpt/push-api/pushEvent.any.serviceworker.html

Weird, this test never failed for this patch, and looks to be flaky on some bots.
Let's try again.
Comment 15 EWS 2021-12-20 18:27:02 PST 
Committed r287294 (245446@main): <https://commits.webkit.org/245446@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447522 [details].