Bug 232639

Summary:

[WebIDL] convertVariadicArguments() should return a FixedVector

Product:

WebKit

Reporter:

Alexey Shvayka <ashvayka>

Component:

Bindings

Assignee:

Alexey Shvayka <ashvayka>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

benjamin, berto, cdumez, cgarcia, changseok, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gustavo, gyuyoung.kim, hta, jer.noble, kangil.han, macpherson, menard, philipj, sergio, tommyw, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none

Alexey Shvayka

Reported 2021-11-02 14:42:41 PDT

[WebIDL] convertVariadicArguments() should return a FixedVector

Attachments
Patch (52.67 KB, patch) 2021-11-02 14:45 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (55.10 KB, patch) 2021-11-02 16:40 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (55.50 KB, patch) 2021-11-03 02:14 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (57.14 KB, patch) 2021-11-04 16:01 PDT, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch (60.40 KB, patch) 2021-12-17 15:28 PST, Alexey Shvayka	no flags	Details Formatted Diff Diff
Patch for landing (60.39 KB, patch) 2021-12-18 09:39 PST, Alexey Shvayka	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Alexey Shvayka

Comment 1 2021-11-02 14:45:18 PDT

Created attachment 443136 [details] Patch

Yusuke Suzuki

Comment 2 2021-11-02 15:00:23 PDT

Comment on attachment 443136 [details] Patch r=me

Alexey Shvayka

Comment 3 2021-11-02 16:40:29 PDT

Created attachment 443145 [details] Patch Make the change for deprecated document.createTouchList() as well.

Alexey Shvayka

Comment 4 2021-11-03 02:14:31 PDT

Created attachment 443181 [details] Patch Add missing FixedVector imports.

Alexey Shvayka

Comment 5 2021-11-04 16:01:17 PDT

Created attachment 443350 [details] Patch Add some more FixedVector imports.

Radar WebKit Bug Importer

Comment 6 2021-12-09 13:16:41 PST

<rdar://problem/86287565>

Alexey Shvayka

Comment 7 2021-12-17 15:28:34 PST

Created attachment 447484 [details] Patch Add / remove tokens in WebKitDOMDOMTokenList one-by-one.

EWS Watchlist

Comment 8 2021-12-17 15:29:29 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Alexey Shvayka

Comment 9 2021-12-18 08:03:35 PST

Comment on attachment 447484 [details] Patch (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 443136 [details] > Patch > > r=me Thanks for review, Yusuke!

EWS

Comment 10 2021-12-18 08:59:31 PST

Patch 447484 does not build

Alexey Shvayka

Comment 11 2021-12-18 09:39:59 PST

Created attachment 447522 [details] Patch for landing

Alexey Shvayka

Comment 12 2021-12-18 09:40:18 PST

(In reply to Alexey Shvayka from comment #11) > Created attachment 447522 [details] > Patch for landing Rebase on top of r287220.

EWS

Comment 13 2021-12-18 11:43:07 PST

Found 1 new test failure: http/wpt/push-api/pushEvent.any.serviceworker.html

Alexey Shvayka

Comment 14 2021-12-20 17:52:26 PST

Comment on attachment 447522 [details] Patch for landing (In reply to EWS from comment #13) > Found 1 new test failure: http/wpt/push-api/pushEvent.any.serviceworker.html Weird, this test never failed for this patch, and looks to be flaky on some bots. Let's try again.

EWS

Comment 15 2021-12-20 18:27:02 PST

Committed r287294 (245446@main): <https://commits.webkit.org/245446@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447522 [details].

Note You need to log in before you can comment on or make changes to this bug.