Summary: | [GLIB] Many network process crashes when running WPT tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | Tools / Tests | Assignee: | Carlos Garcia Campos <cgarcia> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, cdumez, cgarcia, crzwdjk, ews-watchlist, Hironori.Fujii, lmoura, mcatanzaro, pnormand, rego, svillar, webkit-bug-importer | ||||
Priority: | P1 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Martin Robinson
2021-11-02 10:32:14 PDT
That might be related with the RTKit stuff landed recently I think. Does this crash happen also after reverting r284525 ? (In reply to Philippe Normand from comment #1) > That might be related with the RTKit stuff landed recently I think. Why do you think it's related? I don't think there are user interactive threads in the network process Oh, I see STDERR: (process:538): GLib-CRITICAL **: 10:07:18.446: Failed to set scheduler settings: Operation not permitted I can confirm that reverting the patch that Philippe mentions fixes this issue. I don't think it's rtkit in any case, because there aren't user interactive threads in the network process and we don't use g_error when it fails. That message comes from GLib and it might be this https://gitlab.gnome.org/GNOME/tracker/-/issues/180 FTR, I'm also getting this crash consistently with the following non-WPT test locally: http/tests/media/media-blocked-by-willsendrequest.html In the bots, it timeouts instead. Created attachment 445024 [details]
Patch to workaround the issue
Committed r286132 (244519@main): <https://commits.webkit.org/244519@main> Reopening because landed patch is just a workaround. Note that isInsideFlatpak() always returns true in the NetworkProcess when the sandbox is enabled, since it just checks for /.flatpak-info, which gets created by BubblewrapLauncher.cpp even if you're not running inside flatpak. (In reply to Martin Robinson from comment #0) > STDERR: (process:538): GLib-CRITICAL **: 10:07:18.446: Failed to set > scheduler settings: Operation not permitted Is it caused by selinux? (In reply to Michael Catanzaro from comment #12) > Note that isInsideFlatpak() always returns true in the NetworkProcess when > the sandbox is enabled, since it just checks for /.flatpak-info, which gets > created by BubblewrapLauncher.cpp even if you're not running inside flatpak. But we are not sandboxing the network process Oh yeah, nevermind. :P Pull request: https://github.com/WebKit/WebKit/pull/8093 Committed 258379@main (5b9af92f602e): <https://commits.webkit.org/258379@main> Reviewed commits have been landed. Closing PR #8093 and removing active labels. |