Bug 232626

Summary: [iOS] Always set audio session preferred input after changing the category
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Eric Carlson
Reported 2021-11-02 08:56:39 PDT
Setting the audio session category resets configuration to defaults, so always reset the preferred input if it has been changed.
Attachments
Patch (14.20 KB, patch)
2021-11-02 10:34 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (14.21 KB, patch)
2021-11-02 14:19 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.40 KB, patch)
2021-11-04 08:04 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2021-11-02 10:21:02 PDT
rdar://81618758
Eric Carlson
Comment 2 2021-11-02 10:34:39 PDT
Created attachment 443105 [details] Patch
youenn fablet
Comment 3 2021-11-02 11:24:19 PDT
Comment on attachment 443105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443105&action=review > Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:295 > +void MediaStreamTrackPrivate::audioUnitWasReconfigured() I am not clear why this is needed and how we transmit this message from GPUProcess back to WebProcess.
Eric Carlson
Comment 4 2021-11-02 14:19:35 PDT
Created attachment 443133 [details] Patch
youenn fablet
Comment 5 2021-11-03 10:39:57 PDT
Comment on attachment 443133 [details] Patch Patch is fine but I am not sure we need the sessionCaptureConfigurationChanged/audioUnitReconfigured mechanism. If it is actually needed, we probably need some IPC to carry it from GPUProcess to WebProcess
Eric Carlson
Comment 6 2021-11-04 08:04:52 PDT
Created attachment 443303 [details] Patch for landing
EWS
Comment 7 2021-12-08 11:35:06 PST
Committed r286669 (244977@main): <https://commits.webkit.org/244977@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443303 [details].
Note You need to log in before you can comment on or make changes to this bug.