Bug 232624

Summary: [JSC] Make sharing of unlinked baseline code possible on JSVALUE32_64
Product: WebKit Reporter: Geza Lore <glore>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: angelos, cdumez, darin, ews-watchlist, jbedard, keith_miller, mark.lam, msaboff, rniwa, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP - EWS sanity check
none
v1
ews-feeder: commit-queue-
v2 - More Windows register conflict fixes
none
v3
none
v4
none
patch without sharing actually enabled
none
fixed jnstricteq
none
Patch none

Geza Lore
Reported 2021-11-02 07:15:01 PDT
[JSC] Enable sharing of unlinked baseline code on JSVALUE32_64
Attachments
WIP - EWS sanity check (204.12 KB, patch)
2021-11-02 07:17 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
v1 (206.60 KB, patch)
2021-11-02 08:38 PDT, Geza Lore 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
v2 - More Windows register conflict fixes (207.33 KB, patch)
2021-11-02 09:22 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
v3 (213.77 KB, patch)
2021-11-03 04:51 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
v4 (218.85 KB, patch)
2021-11-04 05:58 PDT, Geza Lore 		no flags
DetailsFormatted DiffDiff
patch without sharing actually enabled (218.59 KB, patch)
2021-11-09 01:58 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
fixed jnstricteq (219.41 KB, patch)
2021-11-10 07:11 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
Patch (225.52 KB, patch)
2021-11-15 06:08 PST, Geza Lore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Geza Lore
Comment 1 2021-11-02 07:17:19 PDT
Created attachment 443087 [details] WIP - EWS sanity check
Geza Lore
Comment 2 2021-11-02 08:38:20 PDT
Created attachment 443094 [details] v1
Geza Lore
Comment 3 2021-11-02 09:22:11 PDT
Created attachment 443100 [details] v2 - More Windows register conflict fixes
Geza Lore
Comment 4 2021-11-03 04:51:58 PDT
Created attachment 443189 [details] v3
Geza Lore
Comment 5 2021-11-04 05:58:53 PDT
Created attachment 443297 [details] v4
Geza Lore
Comment 6 2021-11-09 01:58:25 PST
Created attachment 443662 [details] patch without sharing actually enabled
Radar WebKit Bug Importer
Comment 7 2021-11-09 06:15:23 PST
<rdar://problem/85200009>
Geza Lore
Comment 8 2021-11-10 07:11:44 PST
Created attachment 443817 [details] fixed jnstricteq
Geza Lore
Comment 9 2021-11-15 06:08:14 PST
Created attachment 444242 [details] Patch
Yusuke Suzuki
Comment 10 2021-11-19 20:13:34 PST
Comment on attachment 444242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444242&action=review r=me > Source/JavaScriptCore/jit/AssemblyHelpers.h:284 > +#elif USE(JSVALUE32_64) There is no other config, so you can just use "#else" > Source/JavaScriptCore/jit/AssemblyHelpers.h:1080 > +#elif USE(JSVALUE32_64) Ditto. > Source/JavaScriptCore/jit/AssemblyHelpers.h:1089 > +#elif USE(JSVALUE32_64) Ditto. > Source/JavaScriptCore/jit/AssemblyHelpers.h:1168 > +#elif USE(JSVALUE32_64) Ditto.
EWS
Comment 11 2021-11-22 04:14:35 PST
Committed r286111 (244498@main): <https://commits.webkit.org/244498@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444242 [details].
Note You need to log in before you can comment on or make changes to this bug.