Bug 232596 – ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Fujii Hironori]

Since r284764, MSVC reports the following warning.

C:\home\webkit\gc\Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
C:\home\webkit\gc\Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string

[Fujii Hironori]

Created attachment 443037 [details]
Patch

[Simon Fraser (smfr)]

Can we fix the style checker to catch this?

[Fujii Hironori]

(In reply to Simon Fraser (smfr) from comment #2)
> Can we fix the style checker to catch this?

The style checker doesn't compile, doesn't know the type of variable.
AppleWin treats warning as error. But, unfortunately, it suppresses warnings introduced in Visual Studio 2013 (major version 18) and later. 

> add_compile_options(/WX /Wv:18)

https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level

[EWS]

Committed r285150 (243787@main): <https://commits.webkit.org/243787@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443037 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84911625>