Bug 232587

Summary: Add ddkilzer's GitHub name to contributors.json
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232592
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2021-11-01 15:32:23 PDT
Add ddkilzer's GitHub name to contributors.json/
Attachments
Patch v1 (1.00 KB, patch)
2021-11-01 15:34 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-11-01 15:34:12 PDT
Created attachment 443022 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2021-11-01 16:04:06 PDT
LOL...why are we even building anything with changes to the metadata/contributors.json file? At most we should probably run tools (webkitperl/webkitpy) tests and maybe the style test. Actually, webkitpy is strangely missing from the bubble list.
David Kilzer (:ddkilzer)
Comment 3 2021-11-01 16:16:45 PDT
(In reply to David Kilzer (:ddkilzer) from comment #2) > LOL...why are we even building anything with changes to the > metadata/contributors.json file? At most we should probably run tools > (webkitperl/webkitpy) tests and maybe the style test. > > Actually, webkitpy is strangely missing from the bubble list. Bug 232592: Changes to metadata/contributors.json shouldn't run builds (only style/tools tests)
EWS
Comment 4 2021-11-01 16:29:42 PDT
Committed r285144 (243781@main): <https://commits.webkit.org/243781@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443022 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-01 16:30:19 PDT
<rdar://problem/84905946>
Note You need to log in before you can comment on or make changes to this bug.