| Summary: | [WebGPU] Bindings part 2: Bring back Buffer bindings code | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, annulen, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2021-11-01 01:46:56 PDT
Created attachment 442966 [details]
Patch
Created attachment 442967 [details]
Patch
Comment on attachment 442967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442967&action=review > Source/WebCore/Modules/WebGPU/GPUBufferUsage.h:33 > +using GPUBufferUsageFlags = uint32_t; It looks like this could currently be uint16_t Comment on attachment 442967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442967&action=review > Source/WebCore/Modules/WebGPU/GPUBufferUsage.idl:32 > +interface GPUBufferUsage { This should be SecureContext > Source/WebCore/Modules/WebGPU/GPUMapMode.idl:32 > +interface GPUMapMode { Ditto. Comment on attachment 442967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442967&action=review >> Source/WebCore/Modules/WebGPU/GPUBufferUsage.h:33 >> +using GPUBufferUsageFlags = uint32_t; > > It looks like this could currently be uint16_t The IDL has typedef [EnforceRange] unsigned long GPUBufferUsageFlags; I don't think we should deviate from that. Committed r285377 (243934@main): <https://commits.webkit.org/243934@main> |