Bug 232560

Summary: [WebGPU] Bindings part 2: Bring back Buffer bindings code
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch achristensen: review+

Myles C. Maxfield
Reported 2021-11-01 01:46:56 PDT
[WebGPU] Bindings part 2: Bring back Buffer bindings code
Attachments
Patch (42.70 KB, patch)
2021-11-01 01:48 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (42.76 KB, patch)
2021-11-01 02:03 PDT, Myles C. Maxfield 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-11-01 01:48:41 PDT
Created attachment 442966 [details] Patch
Myles C. Maxfield
Comment 2 2021-11-01 02:03:07 PDT
Created attachment 442967 [details] Patch
Alex Christensen
Comment 3 2021-11-01 15:07:23 PDT
Comment on attachment 442967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442967&action=review > Source/WebCore/Modules/WebGPU/GPUBufferUsage.h:33 > +using GPUBufferUsageFlags = uint32_t; It looks like this could currently be uint16_t
Myles C. Maxfield
Comment 4 2021-11-01 22:09:21 PDT
Comment on attachment 442967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442967&action=review > Source/WebCore/Modules/WebGPU/GPUBufferUsage.idl:32 > +interface GPUBufferUsage { This should be SecureContext > Source/WebCore/Modules/WebGPU/GPUMapMode.idl:32 > +interface GPUMapMode { Ditto.
Myles C. Maxfield
Comment 5 2021-11-04 18:40:57 PDT
Comment on attachment 442967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442967&action=review >> Source/WebCore/Modules/WebGPU/GPUBufferUsage.h:33 >> +using GPUBufferUsageFlags = uint32_t; > > It looks like this could currently be uint16_t The IDL has typedef [EnforceRange] unsigned long GPUBufferUsageFlags; I don't think we should deviate from that.
Myles C. Maxfield
Comment 6 2021-11-06 14:09:11 PDT
Committed r285377 (243934@main): <https://commits.webkit.org/243934@main>
Radar WebKit Bug Importer
Comment 7 2021-11-06 14:10:17 PDT
<rdar://problem/85104537>
Note You need to log in before you can comment on or make changes to this bug.