Summary: | Add a run-webkit-tests mode to A/B test a given feature | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, dino, ews-watchlist, glenn, heycam, jbedard, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2021-10-31 21:52:09 PDT
Created attachment 442954 [details]
Patch
I am super open to naming adjustments (I've solicited suggestions elsewhere, hopefully the patch helps people come up with something), I don't love the name as-is. (In reply to Tim Horton from comment #2) > I am super open to naming adjustments (I've solicited suggestions elsewhere, > hopefully the patch helps people come up with something), I don't love the > name as-is. The name is the only thing I don't love....just some brainstormed options: --compare-feature --ab-test-feature --feature-heade I guess the problem I see is that the flag name is so long, maybe we keep the long name but also add a short one (maybe even just --ab or --feature) as an alternative I think the tricky part is you want the long name to cover both the fact that it is running the tests in a weird way AND explain what the value of the argument should be (our test header format), thus the length. I did originally have `--ab-header`, but I'm not sure `ab` very well conveys `A/B` :) Maybe it does! Created attachment 443000 [details]
Patch
Committed r285132 (243771@main): <https://commits.webkit.org/243771@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443000 [details]. |