Bug 232547

Summary:

Update GPU Process feature flags

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

WebKit Misc.

Assignee:

Jon Lee <jonlee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jbedard, peng.liu6, sabouhallawa, simon.fraser, webkit-bug-importer, wenson_hsieh, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	wenson_hsieh: review+
Patch for landing	none
Patch for landing	none
Patch for landing	none

Jon Lee

Reported 2021-10-31 12:37:25 PDT

rdar://83905400

Attachments
Patch (6.11 KB, patch) 2021-10-31 12:53 PDT, Jon Lee	no flags	Details Formatted Diff Diff
Patch (9.17 KB, patch) 2021-11-30 11:51 PST, Jon Lee	wenson_hsieh: review+	Details Formatted Diff Diff
Patch for landing (9.53 KB, patch) 2021-12-02 12:47 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch for landing (9.15 KB, patch) 2021-12-02 23:48 PST, Jon Lee	no flags	Details Formatted Diff Diff
Patch for landing (9.13 KB, patch) 2021-12-05 22:45 PST, Jon Lee	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jon Lee

Comment 1 2021-10-31 12:53:52 PDT

Created attachment 442938 [details] Patch

Wenson Hsieh

Comment 2 2021-11-01 07:53:27 PDT

Is the intention to also enable DOM in GPU Process by default in layout tests?

Jon Lee

Comment 3 2021-11-01 15:19:20 PDT

(In reply to Wenson Hsieh from comment #2) > Is the intention to also enable DOM in GPU Process by default in layout > tests? Good point. It is not, yet.

Jon Lee

Comment 4 2021-11-30 11:51:23 PST

Created attachment 445449 [details] Patch

Wenson Hsieh

Comment 5 2021-12-01 16:04:09 PST

Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:954 > +# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely. Nit - let's fix the "relevant" spelling while we're moving this flag

Jonathan Bedard

Comment 6 2021-12-01 16:06:58 PST

Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:-384 > - options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled') Is `WebRTCPlatformCodecsInGPUProcessEnabled` now an internal feature because it's implicitly part of `UseGPUProcessForDOMRenderingEnabled`?

Wenson Hsieh

Comment 7 2021-12-01 16:08:48 PST

Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review >> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:-384 >> - options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled') > > Is `WebRTCPlatformCodecsInGPUProcessEnabled` now an internal feature because it's implicitly part of `UseGPUProcessForDOMRenderingEnabled`? Based on the WTF changelog, It's an internal feature because we've shipped it (on by default) already.

Peng Liu

Comment 8 2021-12-02 10:46:49 PST

Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:162 > + condition: ENABLE(MEDIA_STREAM) Probably we need to add `ENABLE(GPU_PROCESS)` here? > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:959 > + condition: ENABLE(WEB_RTC) Need to add `ENABLE(GPU_PROCESS)` as well?

Jon Lee

Comment 9 2021-12-02 10:49:57 PST

(In reply to Jonathan Bedard from comment #6) > Comment on attachment 445449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445449&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:-384 > > - options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled') > > Is `WebRTCPlatformCodecsInGPUProcessEnabled` now an internal feature because > it's implicitly part of `UseGPUProcessForDOMRenderingEnabled`? No. It's part of WebRTC, and is enabled by default. I'm moving features we turned on by default in our last release to internal. The flags are useful for testing, but they're no longer experimental.

Jon Lee

Comment 10 2021-12-02 10:50:20 PST

(In reply to Peng Liu from comment #8) > Comment on attachment 445449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445449&action=review > > > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:162 > > + condition: ENABLE(MEDIA_STREAM) > > Probably we need to add `ENABLE(GPU_PROCESS)` here? > > > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:959 > > + condition: ENABLE(WEB_RTC) > > Need to add `ENABLE(GPU_PROCESS)` as well? I didn't touch these but can add them.

Jon Lee

Comment 11 2021-12-02 12:47:01 PST

Created attachment 445764 [details] Patch for landing

Jon Lee

Comment 12 2021-12-02 23:48:08 PST

Created attachment 445816 [details] Patch for landing

EWS

Comment 13 2021-12-05 22:21:37 PST

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Jon Lee

Comment 14 2021-12-05 22:45:06 PST

Created attachment 446000 [details] Patch for landing

EWS

Comment 15 2021-12-06 11:23:02 PST

Committed r286554 (244884@main): <https://commits.webkit.org/244884@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446000 [details].

Note You need to log in before you can comment on or make changes to this bug.