| Summary: | [WTF] Minor clean-up for format-related functions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Component: | Web Template Framework | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, bfulgham, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
David Kilzer (:ddkilzer)
2021-10-29 15:50:39 PDT
Created attachment 442876 [details]
Patch v1
Comment on attachment 442876 [details]
Patch v1
Need to compile macOS as well!
Created attachment 443129 [details]
Patch v2
(In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 443129 [details] > Patch v2 Dropped the changes to Assertions.h since macOS has some `LOG()` calls that don't have any arguments past the `format` string. Comment on attachment 443129 [details]
Patch v2
r=me
Comment on attachment 443129 [details]
Patch v2
Marking as cq+ since this built successfully on a sufficient number of platforms.
Committed r285188 (243817@main): <https://commits.webkit.org/243817@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443129 [details]. |