| Summary: | [watchOS] Fix logging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, sihui_liu, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2021-10-27 23:20:33 PDT
Created attachment 442677 [details]
Patch
Committed r284988 (243635@main): <https://commits.webkit.org/243635@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442677 [details]. Comment on attachment 442677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442677&action=review > Source/WebCore/ChangeLog:10 > + OSStatus is typedef'ed to an SInt32. On watchOS, SInt32 is typedef'ed to be a signed long. > + A signed long on watchOS is 4 bytes long. On non-watchOS, SInt32 is typedef'ed to be a signed int. > + So, if we want to use printf formatting strings, we have to cast the OSStatus to an int. It sounds like it would be nicer to cast it to signed long instead, given this explanation. Comment on attachment 442677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442677&action=review >> Source/WebCore/ChangeLog:10 >> + So, if we want to use printf formatting strings, we have to cast the OSStatus to an int. > > It sounds like it would be nicer to cast it to signed long instead, given this explanation. Really? OSStatus ends up being 4 bytes on every platform, and int is also 4 bytes on every platform - so I thought it would be a perfect fit. Why is long better? |