| Summary: | Assertions in findFirstSlotElement hit when removing two slots with the same name in a single shadow tree | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gabriel Nava Marino <gnavamarino> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, esprehn+autocc, ews-watchlist, kangil.han, koivisto, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 148695 | ||||||||
| Attachments: |
|
||||||||
|
Description
Gabriel Nava Marino
2021-10-27 15:42:47 PDT
Created attachment 442641 [details]
Patch
Comment on attachment 442641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442641&action=review > LayoutTests/fast/shadow-dom/slot-removal-same-name.html:1 > +<script> Missing DOCTYPE? > LayoutTests/fast/shadow-dom/slot-removal-same-name.html:3 > + let shadow0 = document.body.attachShadow({mode: 'open'}); Can we call this just shadowRoot? Also, use const since we're reassigning another value to it. > LayoutTests/fast/shadow-dom/slot-removal-same-name.html:6 > + document.body.offsetTop; document.body.getBoundingClientRect() is more sure way of ensuring updating the layout. offsetTop can be optimized in some cases. Created attachment 442644 [details]
Patch
Address feedback comments. Committed r284969 (243620@main): <https://commits.webkit.org/243620@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442644 [details]. |