Bug 232390 – [WebAuthn] +[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials] should include kSecAttrCreationDate and kSecAttrModificationDate in the data dictionaries

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[[e-mail]]

<rdar://problem/84689277>

[[e-mail]]

Created attachment 442610 [details]
Patch

[[e-mail]]

Created attachment 442612 [details]
Patch

[Darin Adler]

Comment on attachment 442612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442612&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:256
> +            _WKLocalAuthenticatorCredentialIDKey : attributes[bridge_id_cast(kSecAttrApplicationLabel)],
> +            _WKLocalAuthenticatorCredentialRelyingPartyIDKey : attributes[bridge_id_cast(kSecAttrLabel)],
> +            _WKLocalAuthenticatorCredentialLastModificationDateKey : attributes[bridge_id_cast(kSecAttrModificationDate)],
> +            _WKLocalAuthenticatorCredentialCreationDateKey : attributes[bridge_id_cast(kSecAttrCreationDate)]

bridge_cast also works here, and I suggest always using bridge_cast unless you must use bridge_id cast.

Also, there’s a formatting change here where you are added spaces before the colons and before the "{", and I am not sure why.

[[e-mail]]

(In reply to Darin Adler from comment #3)
> Comment on attachment 442612 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442612&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:256
> > +            _WKLocalAuthenticatorCredentialIDKey : attributes[bridge_id_cast(kSecAttrApplicationLabel)],
> > +            _WKLocalAuthenticatorCredentialRelyingPartyIDKey : attributes[bridge_id_cast(kSecAttrLabel)],
> > +            _WKLocalAuthenticatorCredentialLastModificationDateKey : attributes[bridge_id_cast(kSecAttrModificationDate)],
> > +            _WKLocalAuthenticatorCredentialCreationDateKey : attributes[bridge_id_cast(kSecAttrCreationDate)]
> 
> bridge_cast also works here, and I suggest always using bridge_cast unless
> you must use bridge_id cast.
> 
> Also, there’s a formatting change here where you are added spaces before the
> colons and before the "{", and I am not sure why.

I tried running "webkit-patch format" for the first time on this. Noticed how it changed the formatting here: https://bugs.webkit.org/attachment.cgi?id=442610&action=diff#a/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h_sec1 and undid that, but didn't catch the difference here.

[[e-mail]]

Created attachment 442657 [details]
Patch

[[e-mail]]

Also, thank you for the review!

[Darin Adler]

Comment on attachment 442657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442657&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:251
> +        [result addObject:@ {

We normally don’t put a space after the "@" and before the "{".

[[e-mail]]

Created attachment 442658 [details]
Patch

[EWS]

Committed r285056 (243699@main): <https://commits.webkit.org/243699@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442658 [details].