Bug 232371

Summary: Fetch API: Network process leaks when blobs are unused
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, ggaren, kondapallykalyan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 151937, 232357    
Attachments:
Description Flags
Demonstrate Network process leak
none
Patch
ews-feeder: commit-queue-
Patch none

Description Kimmo Kinnunen 2021-10-27 04:00:12 PDT
Fetch API: Network process leaks when blobs are unused

See the attached test case for creating 10gb leak in network process
Comment 1 Kimmo Kinnunen 2021-10-27 04:01:35 PDT
Created attachment 442577 [details]
Demonstrate Network process leak
Comment 2 Radar WebKit Bug Importer 2021-10-27 04:09:59 PDT
<rdar://problem/84704184>
Comment 3 youenn fablet 2021-10-27 06:29:47 PDT
We are probably not unregistering blobs somewhere.
Comment 4 youenn fablet 2021-10-27 06:31:22 PDT
Hum, in Blob constructor, we have recently added registering the internal URL but I do not see where we are actually unregistering it.
That might be the issue.
Comment 5 youenn fablet 2021-10-27 07:10:42 PDT
Created attachment 442586 [details]
Patch
Comment 6 youenn fablet 2021-10-27 07:16:31 PDT
Created attachment 442587 [details]
Patch
Comment 7 Geoffrey Garen 2021-10-27 11:30:05 PDT
Comment on attachment 442587 [details]
Patch

r=me
Comment 8 EWS 2021-10-28 00:32:38 PDT
Committed r284971 (243621@main): <https://commits.webkit.org/243621@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442587 [details].