Bug 232359

Summary: Web Inspector: Enable -Wformat=2 warnings
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web InspectorAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2021-10-26 19:16:36 PDT
Enable -Wformat=2 warnings in WebInspectorUI project. There are no warnings to fix with this change. This is simply to keep warning flags in sync with other WebKit projects.
Attachments
Patch v1 (1.87 KB, patch)
2021-10-26 19:19 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-26 19:16:46 PDT
<rdar://problem/84691442>
David Kilzer (:ddkilzer)
Comment 2 2021-10-26 19:19:07 PDT
Created attachment 442556 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2021-10-27 16:36:28 PDT
Super easy patch to review. Only changes a switch in WARNING_CFLAGS. Ignore any test errors as those are undiagnosed flaky tests since this doesn't have any code changes. :)
EWS
Comment 4 2021-10-29 08:52:45 PDT
Committed r285031 (243675@main): <https://commits.webkit.org/243675@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442556 [details].
Note You need to log in before you can comment on or make changes to this bug.