Bug 232335

Summary:

[WebRTC] Enable -Wformat=2 warnings

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebRTC

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, eric.carlson, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/cisco/libsrtp/issues/576
https://bugs.chromium.org/p/webm/issues/detail?id=1744

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2021-10-26 14:48:13 PDT

Enable -Wformat=2 warnings in libwebrtc project.

This includes -Wformat-nonliteral among other warnings.

<rdar://problem/84571752>

Comment 1 David Kilzer (:ddkilzer) 2021-10-26 15:11:08 PDT

Created attachment 442536 [details]
Patch v1

Comment 2 David Kilzer (:ddkilzer) 2021-10-26 19:01:22 PDT

Comment on attachment 442536 [details]
Patch v1

Marking cq+ since this is a compile-time change that doesn't result in any differences in code generation.

Comment 3 EWS 2021-10-27 11:09:03 PDT

Committed r284929 (243599@main): <https://commits.webkit.org/243599@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442536 [details].