Bug 232332

Summary: Remove properties set by NSURLProtocol on NSURLRequest before serializing
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Alex Christensen 2021-10-26 14:27:30 PDT 
Remove properties set by NSURLProtocol on NSURLRequest before serializing
Comment 1 Alex Christensen 2021-10-26 14:31:49 PDT 
Created attachment 442531 [details]
Patch
Comment 2 Geoffrey Garen 2021-10-26 14:56:59 PDT 
Comment on attachment 442531 [details]
Patch

r=me
Comment 3 Alex Christensen 2021-10-26 17:27:30 PDT 
Created attachment 442547 [details]
Patch
Comment 4 Alex Christensen 2021-10-26 17:31:20 PDT 
Created attachment 442548 [details]
Patch
Comment 5 EWS 2021-10-26 20:11:43 PDT 
Committed r284917 (243588@main): <https://commits.webkit.org/243588@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442548 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-26 20:12:17 PDT 
<rdar://problem/84692742>
Comment 7 Alex Christensen 2021-10-29 16:18:07 PDT 
Reverted in http://trac.webkit.org/r285059
Will try again once respondsToSelector is no longer necessary.
Comment 8 Alex Christensen 2021-10-29 16:18:52 PDT 
Another thing worth trying would be instead of always calling mutableCopy, check to see if it's already mutable.
Comment 9 Alex Christensen 2021-12-14 14:36:43 PST 
Created attachment 447165 [details]
Patch
Comment 10 EWS 2021-12-14 15:49:36 PST 
Committed r287056 (245252@main): <https://commits.webkit.org/245252@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447165 [details].
Comment 11 Alex Christensen 2021-12-16 09:17:41 PST 
Reverted in http://trac.webkit.org/r287141
It seems my theory that the original perf regression was caused by respondsToSelector was incorrect.