Bug 232332

Summary: Remove properties set by NSURLProtocol on NSURLRequest before serializing
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Alex Christensen
Reported 2021-10-26 14:27:30 PDT
Remove properties set by NSURLProtocol on NSURLRequest before serializing
Attachments
Patch (6.38 KB, patch)
2021-10-26 14:31 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.52 KB, patch)
2021-10-26 17:27 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.53 KB, patch)
2021-10-26 17:31 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (7.87 KB, patch)
2021-12-14 14:36 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-26 14:31:49 PDT
Created attachment 442531 [details] Patch
Geoffrey Garen
Comment 2 2021-10-26 14:56:59 PDT
Comment on attachment 442531 [details] Patch r=me
Alex Christensen
Comment 3 2021-10-26 17:27:30 PDT
Created attachment 442547 [details] Patch
Alex Christensen
Comment 4 2021-10-26 17:31:20 PDT
Created attachment 442548 [details] Patch
EWS
Comment 5 2021-10-26 20:11:43 PDT
Committed r284917 (243588@main): <https://commits.webkit.org/243588@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442548 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-26 20:12:17 PDT
<rdar://problem/84692742>
Alex Christensen
Comment 7 2021-10-29 16:18:07 PDT
Reverted in http://trac.webkit.org/r285059 Will try again once respondsToSelector is no longer necessary.
Alex Christensen
Comment 8 2021-10-29 16:18:52 PDT
Another thing worth trying would be instead of always calling mutableCopy, check to see if it's already mutable.
Alex Christensen
Comment 9 2021-12-14 14:36:43 PST
Created attachment 447165 [details] Patch
EWS
Comment 10 2021-12-14 15:49:36 PST
Committed r287056 (245252@main): <https://commits.webkit.org/245252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447165 [details].
Alex Christensen
Comment 11 2021-12-16 09:17:41 PST
Reverted in http://trac.webkit.org/r287141 It seems my theory that the original perf regression was caused by respondsToSelector was incorrect.
Note You need to log in before you can comment on or make changes to this bug.