Summary: | Fails to execute JavaScript when soft stack limit is unlimited | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | Web Template Framework | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, bugs-noreply, cdumez, cmarcelo, dkolesa, ews-watchlist, mcatanzaro, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
See Also: | https://bugzilla.redhat.com/show_bug.cgi?id=2017281 | ||||||
Attachments: |
|
Description
Michael Catanzaro
2021-10-26 12:59:27 PDT
let's have it max out at 8M, realistically there is nothing better you can do i think Actually I'm not certain it's really a regression, because there are preexisting calls to pthread_getattr_np() (or pthread_get_stacksize_np() on Darwin) that would likely have had the same problem. (In reply to Daniel Kolesa from comment #1) > let's have it max out at 8M, realistically there is nothing better you can > do i think Sounds good. (In reply to Michael Catanzaro from comment #0) > When the limit is unlimited, > rlim_cur is -1 and the function is not prepared for that. Actually, it is RLIM_INFINITY. Doesn't change the rest of the analysis, though. Created attachment 442530 [details]
Patch
(In reply to Michael Catanzaro from comment #2) > Actually I'm not certain it's really a regression, because there are > preexisting calls to pthread_getattr_np() (or pthread_get_stacksize_np() on > Darwin) that would likely have had the same problem. I think it's OK because this returns the real stack size, not the limit. Also, it works fine in practice with no changes to this. patch lgtm Ping reviewers Comment on attachment 442530 [details]
Patch
r=me
Committed r285187 (243816@main): <https://commits.webkit.org/243816@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442530 [details]. |