Summary: | Possible non-unified build issues | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Kolesa <dkolesa> | ||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | don.olmstead, dpino, ews-watchlist, Hironori.Fujii, jiewen_tan, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Mac (Intel) | ||||||||||
OS: | macOS 10.15 | ||||||||||
Attachments: |
|
Description
Daniel Kolesa
2021-10-26 10:42:21 PDT
Created attachment 442507 [details]
possible patch
Created attachment 442508 [details]
fixed patch
apologies, somehow i submitted a malformed patch
Comment on attachment 442508 [details] fixed patch View in context: https://bugs.webkit.org/attachment.cgi?id=442508&action=review > Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h:34 > +#include <variant> style checker EWS is failing. ERROR: Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.h:34: Alphabetical sorting problem. [build/include_order] [4] (In reply to Daniel Kolesa from comment #0) > but have no good way to explicitly verify that. There is a experimental CMake build of Mac port, and CMake has ENABLE_UNIFIED_BUILDS option. However, this patch looks no problem to me. Created attachment 442688 [details]
fixed style (no functional changes)
well then, thanks
fixed style
Comment on attachment 442688 [details] fixed style (no functional changes) View in context: https://bugs.webkit.org/attachment.cgi?id=442688&action=review I'll just r+ this on Fujii's behalf but in the future that's the workflow when you get an r+ but a cq-. > Source/WebKit/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). When you get an r+ in a previous patch with nits what you do is you replace the `NOBODY (OOPS!)` and then a cq+ is all that's needed. (In reply to Don Olmstead from comment #6) > Comment on attachment 442688 [details] > fixed style (no functional changes) > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442688&action=review > > I'll just r+ this on Fujii's behalf but in the future that's the workflow > when you get an r+ but a cq-. > > > Source/WebKit/ChangeLog:6 > > + Reviewed by NOBODY (OOPS!). > > When you get an r+ in a previous patch with nits what you do is you replace > the `NOBODY (OOPS!)` and then a cq+ is all that's needed. In this case the line would've been Reviewed by Fujii Hironori. You can just search the ChangeLog and copy paste the reviewer's name from there. Committed r284990 (243636@main): <https://commits.webkit.org/243636@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442688 [details].
> I'll just r+ this on Fujii's behalf but in the future that's the workflow
> when you get an r+ but a cq-.
noted, thanks
|