error event should be fired at <style> element when @import rule fails parsing due to MIME type

• Component: CSS
• Status: RESOLVED FIXED

[Chris Dumez]

error event should be fired at <style> element when @import rule fails parsing due to MIME type.

[Chris Dumez]

Created attachment 442501 [details]
Patch

[Chris Dumez]

Created attachment 442512 [details]
Patch

[Darin Adler]

Comment on attachment 442512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442512&action=review

> Source/WebCore/css/StyleRuleImport.cpp:78
> +    if (!m_styleSheet->parseAuthorStyleSheet(cachedStyleSheet, document ? &document->securityOrigin() : nullptr)) {

These are so similar I think a boolean for success would be better:

    bool parseSucceeded = m_styleSheet->parseAuthorStyleSheet(cachedStyleSheet, document ? &document->securityOrigin() : nullptr);

    ...

    if (m_parentStyleSheet) {
        if (parseSucceeded)
            m_parentStyleSheet->notifyLoadedSheet(cachedStyleSheet);
        else
            m_parentStyleSheet->setLoadErrorOccured();
        ...

[Chris Dumez]

Created attachment 442523 [details]
Patch

[EWS]

Committed r284898 (243575@main): <https://commits.webkit.org/243575@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442523 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84681815>