Bug 232298

Summary: AX: AXValueChanged is only sent for range elements when value is changed with the keyboard
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, dmazzoni, esprehn+autocc, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, mifenton, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 232300    
Attachments:
Description Flags
Patch
none
Patch andresg_22: review+

Carlos Garcia Campos
Reported 2021-10-26 01:53:05 PDT
It should always be sent when the value changes.
Attachments
Patch (8.92 KB, patch)
2021-10-26 01:56 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (8.92 KB, patch)
2021-10-26 02:43 PDT, Carlos Garcia Campos 		andresg_22: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-26 01:53:18 PDT
<rdar://problem/84653767>
Carlos Garcia Campos
Comment 2 2021-10-26 01:56:53 PDT
Created attachment 442473 [details] Patch
Carlos Garcia Campos
Comment 3 2021-10-26 02:43:06 PDT
Created attachment 442474 [details] Patch
Andres Gonzalez
Comment 4 2021-10-27 08:25:45 PDT
(In reply to Carlos Garcia Campos from comment #3) > Created attachment 442474 [details] > Patch Good fix. Does this tes pass in isolated tree mode? I would think we need to modify the test to wait for the value to be updated in the isolated tree.
Carlos Garcia Campos
Comment 5 2021-10-28 01:34:06 PDT
(In reply to Andres Gonzalez from comment #4) > (In reply to Carlos Garcia Campos from comment #3) > > Created attachment 442474 [details] > > Patch > > Good fix. Does this tes pass in isolated tree mode? I would think we need to > modify the test to wait for the value to be updated in the isolated tree. It works with a patch similar to the one attached to bug #232141. I'm still not sure it's worth rewriting all the tests to make them async when we can just notify earlier about property changes.
Carlos Garcia Campos
Comment 6 2021-10-28 01:36:46 PDT
Committed r284972 (243622@main): <https://commits.webkit.org/243622@main>
Andres Gonzalez
Comment 7 2021-10-31 07:43:45 PDT
(In reply to Carlos Garcia Campos from comment #5) > (In reply to Andres Gonzalez from comment #4) > > (In reply to Carlos Garcia Campos from comment #3) > > > Created attachment 442474 [details] > > > Patch > > > > Good fix. Does this tes pass in isolated tree mode? I would think we need to > > modify the test to wait for the value to be updated in the isolated tree. > > It works with a patch similar to the one attached to bug #232141. I'm still > not sure it's worth rewriting all the tests to make them async when we can > just notify earlier about property changes. Unfortunately I think we have no choice and have to make the tests async. See my comment in https://bugs.webkit.org/show_bug.cgi?id=232141.
Note You need to log in before you can comment on or make changes to this bug.