Summary: | AX: AXValueChanged is only sent for range elements when value is changed with the keyboard | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, dmazzoni, esprehn+autocc, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, mifenton, samuel_white, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 232300 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2021-10-26 01:53:05 PDT
Created attachment 442473 [details]
Patch
Created attachment 442474 [details]
Patch
(In reply to Carlos Garcia Campos from comment #3) > Created attachment 442474 [details] > Patch Good fix. Does this tes pass in isolated tree mode? I would think we need to modify the test to wait for the value to be updated in the isolated tree. (In reply to Andres Gonzalez from comment #4) > (In reply to Carlos Garcia Campos from comment #3) > > Created attachment 442474 [details] > > Patch > > Good fix. Does this tes pass in isolated tree mode? I would think we need to > modify the test to wait for the value to be updated in the isolated tree. It works with a patch similar to the one attached to bug #232141. I'm still not sure it's worth rewriting all the tests to make them async when we can just notify earlier about property changes. Committed r284972 (243622@main): <https://commits.webkit.org/243622@main> (In reply to Carlos Garcia Campos from comment #5) > (In reply to Andres Gonzalez from comment #4) > > (In reply to Carlos Garcia Campos from comment #3) > > > Created attachment 442474 [details] > > > Patch > > > > Good fix. Does this tes pass in isolated tree mode? I would think we need to > > modify the test to wait for the value to be updated in the isolated tree. > > It works with a patch similar to the one attached to bug #232141. I'm still > not sure it's worth rewriting all the tests to make them async when we can > just notify earlier about property changes. Unfortunately I think we have no choice and have to make the tests async. See my comment in https://bugs.webkit.org/show_bug.cgi?id=232141. |