Bug 232283

Summary:

[ Mac wk1 ] 2 media-capabilities/webrtc tests are flaky failures

Product:

WebKit

Reporter:

Eric Hutchison <ehutchison>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ehutchison, eric.carlson, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Description Eric Hutchison 2021-10-25 16:27:54 PDT

imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html
imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html

are flaky failures on Mac wk1.

History:https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-capabilities%2FdecodingInfo.webrtc.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-capabilities%2FencodingInfo.webrtc.html&platform=mac&platform=ios

Build: https://ews-build.webkit.org/#/builders/56/builds/18333

Results: https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Debug-WK1-Tests-EWS/r442381-18333-rerun/results.html

Diff:
--- /Volumes/Data/worker/macOS-Catalina-Debug-WK1-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc-expected.txt
+++ /Volumes/Data/worker/macOS-Catalina-Debug-WK1-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc-actual.txt
@@ -19,8 +19,5 @@
 PASS Test that decodingInfo returns supported true for the codec video/H264; level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f returned by RTCRtpReceiver.getCapabilities()
 PASS Test that decodingInfo returns supported true for the codec video/H264; level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=640c1f returned by RTCRtpReceiver.getCapabilities()
 PASS Test that decodingInfo returns supported true for the codec video/H264; level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42e01f returned by RTCRtpReceiver.getCapabilities()
-PASS Test that decodingInfo returns supported true for the codec video/H265 returned by RTCRtpReceiver.getCapabilities()
 PASS Test that decodingInfo returns supported true for the codec video/VP8 returned by RTCRtpReceiver.getCapabilities()
-PASS Test that decodingInfo returns supported true for the codec video/VP9; profile-id=0 returned by RTCRtpReceiver.getCapabilities()
-PASS Test that decodingInfo returns supported true for the codec video/VP9; profile-id=2 returned by RTCRtpReceiver.getCapabilities()
 

--- /Volumes/Data/worker/macOS-Catalina-Debug-WK1-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc-expected.txt
+++ /Volumes/Data/worker/macOS-Catalina-Debug-WK1-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc-actual.txt
@@ -19,8 +19,5 @@
 PASS Test that encodingInfo returns supported true for the codec video/H264; level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f returned by RTCRtpSender.getCapabilities()
 PASS Test that encodingInfo returns supported true for the codec video/H264; level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=640c1f returned by RTCRtpSender.getCapabilities()
 PASS Test that encodingInfo returns supported true for the codec video/H264; level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42e01f returned by RTCRtpSender.getCapabilities()
-PASS Test that encodingInfo returns supported true for the codec video/H265 returned by RTCRtpSender.getCapabilities()
 PASS Test that encodingInfo returns supported true for the codec video/VP8 returned by RTCRtpSender.getCapabilities()
-PASS Test that encodingInfo returns supported true for the codec video/VP9; profile-id=0 returned by RTCRtpSender.getCapabilities()
-PASS Test that encodingInfo returns supported true for the codec video/VP9; profile-id=2 returned by RTCRtpSender.getCapabilities()
 

13:42:34.344 17406 worker/15 worker/15 imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html output stderr lines:
13:42:34.345 17406 worker/15   (audio_processing_impl.cc:278): Injected APM submodules:
13:42:34.345 17406 worker/15   Echo control factory: 0
13:42:34.345 17406 worker/15   Echo detector: 0
13:42:34.346 17406 worker/15   Capture analyzer: 0
13:42:34.346 17406 worker/15   Capture post processor: 0
13:42:34.346 17406 worker/15   Render pre processor: 0
13:42:34.346 17406 worker/15   (webrtc_voice_engine.cc:268): WebRtcVoiceEngine::WebRtcVoiceEngine
13:42:34.347 17406 worker/15   (webrtc_video_engine.cc:628): WebRtcVideoEngine::WebRtcVideoEngine()
13:42:34.347 17406 worker/15   (webrtc_voice_engine.cc:290): WebRtcVoiceEngine::Init
13:42:34.347 17406 worker/15   (webrtc_voice_engine.cc:386): WebRtcVoiceEngine::ApplyOptions: AudioOptions {aec: 1, agc: 1, ns: 1, hf: 1, swap: 0, audio_jitter_buffer_max_packets: 200, audio_jitter_buffer_fast_accelerate: 0, audio_jitter_buffer_min_delay_ms: 0, audio_jitter_buffer_enable_rtx_handling: 0, typing: 1, experimental_agc: 0, experimental_ns: 0, residual_echo_detector: 1, }
13:42:34.347 17406 worker/15   (webrtc_voice_engine.cc:495): Stereo swapping enabled? 0
13:42:34.348 17406 worker/15   (webrtc_voice_engine.cc:500): NetEq capacity is 200
13:42:34.348 17406 worker/15   (webrtc_voice_engine.cc:506): NetEq fast mode? 0
13:42:34.348 17406 worker/15   (webrtc_voice_engine.cc:512): NetEq minimum delay is 0
13:42:34.348 17406 worker/15   (webrtc_voice_engine.cc:518): NetEq handle reordered packets? 0
13:42:34.349 17406 worker/15   (webrtc_voice_engine.cc:538): Experimental ns is enabled? 0
13:42:34.349 17406 worker/15   (webrtc_voice_engine.cc:589): NS set to 1
13:42:34.349 17406 worker/15   (webrtc_voice_engine.cc:593): Typing detection is enabled? 1
13:42:34.350 17406 worker/15   (audio_processing_impl.cc:533): AudioProcessing::ApplyConfig: AudioProcessing::Config{ pipeline: { maximum_internal_processing_rate: 48000, multi_channel_render: 0, multi_channel_capture: 0 }, pre_amplifier: { enabled: 0, fixed_gain_factor: 1 },capture_level_adjustment: { enabled: 0, pre_gain_factor: 1, post_gain_factor: 1, analog_mic_gain_emulation: { enabled: 0, initial_level: 255 }}, high_pass_filter: { enabled: 1 }, echo_canceller: { enabled: 1, mobile_mode: 0, enforce_high_pass_filtering: 1 }, noise_suppression: { enabled: 1, level: High }, transient_suppression: { enabled: 0 }, voice_detection: { enabled: 1 }, gain_controller1: { enabled: 1, mode: AdaptiveAnalog, target_level_dbfs: 3, compression_gain_db: 9, enable_limiter: 1, analog_level_minimum: 0, analog_level_maximum: 255, analog_gain_controller { enabled: 1, startup_min_volume: 0, clipped_level_min: 70, enable_digital_adaptive: 1 }}, gain_controller2: { enabled: 0, fixed_digital: { gain_db: 0 }, adaptive_digital: { enabled: 0, dry_run: 0, noise_estimator: NoiseFloor, vad_reset_period_ms: 1500, adjacent_speech_frames_threshold: 12, max_gain_change_db_per_second: 3, max_output_noise_level_dbfs: -50, sse2_allowed: 1, avx2_allowed: 1, neon_allowed: 1}}, residual_echo_detector: { enabled: 1 }, level_estimation: { enabled: 0 }}
13:42:34.350 17406 worker/15   (agc_manager_direct.cc:68): [agc] GetMinMicLevel
13:42:34.350 17406 worker/15   (agc_manager_direct.cc:72): [agc] Using default min mic level: 12
13:42:34.350 17406 worker/15   (agc_manager_direct.cc:448): AgcManagerDirect::Initialize

13:42:37.423 17406 worker/15 "ruby -I /Volumes/Data/worker/macOS-Catalina-Debug-WK1-Tests-EWS/build/Websites/bugs.webkit.org/PrettyPatch /Volumes/Data/worker/macOS-Catalina-Debug-WK1-Tests-EWS/build/Websites/bugs.webkit.org/PrettyPatch/prettify.rb /Volumes/Data/worker/macOS-Catalina-Debug-WK1-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc-diff.txt" took 0.40s
13:42:37.424 17406 [41914/56194] imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html failed unexpectedly (text diff)
13:42:37.424 17406 worker/15 imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html failed:
13:42:37.424 17406 worker/15 text diff

Reproduced on ToT (r284819) using run-webkit-tests -1 -f --force --iterations 1000 --exit-after-n-failures 1 --clobber-old-results imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc.html - and - run-webkit-tests -1 -f --force --iterations 1000 --exit-after-n-failures 1 --clobber-old-results imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc.html

Comment 1 Radar WebKit Bug Importer 2021-10-25 16:28:26 PDT

<rdar://problem/84637007>

Comment 2 Eric Hutchison 2021-10-25 16:33:45 PDT

Updated test expectations at https://trac.webkit.org/changeset/284847/webkit

Comment 3 youenn fablet 2021-10-26 03:24:57 PDT

Created attachment 442475 [details]
Patch

Comment 4 EWS 2021-10-28 00:25:53 PDT

Downloading html5lib-1.1.0...
Installing html5lib-1.1.0...
Installed html5lib-1.1.0!
Downloading webencodings-0.5.1...
Installing webencodings-0.5.1...
Installed webencodings-0.5.1!
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 42, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/main.py", line 39, in <module>
    from webkitpy.tool import commands
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/__init__.py", line 3, in <module>
    from webkitpy.tool.commands.applywatchlistlocal import ApplyWatchListLocal
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal.py", line 29, in <module>
    from webkitpy.tool import steps
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/steps/__init__.py", line 55, in <module>
    from webkitpy.tool.steps.postdiff import PostDiff
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/steps/postdiff.py", line 30, in <module>
    from webkitpy.common.net.bugzilla import Attachment
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py", line 4, in <module>
    from webkitpy.common.net.bugzilla.bugzilla import Bugzilla
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 51, in <module>
    from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup, BeautifulStoneSoup, SoupStrainer
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py", line 26, in <module>
    import html5lib
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/html5lib/__init__.py", line 25, in <module>
    from .html5parser import HTMLParser, parse, parseFragment
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/html5lib/html5parser.py", line 6, in <module>
    from . import _inputstream
  File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/html5lib/_inputstream.py", line 10, in <module>
    import webencodings
ModuleNotFoundError: No module named 'webencodings'

Comment 5 youenn fablet 2021-10-28 05:50:45 PDT

Created attachment 442697 [details]
Patch

Comment 6 youenn fablet 2021-10-28 06:01:43 PDT

Created attachment 442699 [details]
Patch for landing

Comment 7 EWS 2021-10-28 06:52:09 PDT

Committed r284976 (243624@main): <https://commits.webkit.org/243624@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442699 [details].