Bug 232270

Summary: [WTF] Make Int128 operator* constexpr
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, philip.chimento, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2021-10-25 14:26:32 PDT
[WTF] Make Int128 operator* constexpr
Attachments
Patch (3.56 KB, patch)
2021-10-25 14:39 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.26 KB, patch)
2021-10-25 14:44 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-10-25 14:39:05 PDT
Created attachment 442420 [details] Patch
Yusuke Suzuki
Comment 2 2021-10-25 14:44:24 PDT
Created attachment 442421 [details] Patch
Philip Chimento
Comment 3 2021-10-25 16:00:05 PDT
Comment on attachment 442421 [details] Patch LGTM, though I'm not a reviewer.
Mark Lam
Comment 4 2021-10-25 16:33:23 PDT
Comment on attachment 442421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442421&action=review r=me > Source/WTF/wtf/Int128.h:811 > +constexpr UInt128Impl operator*(UInt128Impl lhs, UInt128Impl rhs) { Not introduced by you but { belongs on next line.
Yusuke Suzuki
Comment 5 2021-10-25 17:11:28 PDT
Comment on attachment 442421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442421&action=review >> Source/WTF/wtf/Int128.h:811 >> +constexpr UInt128Impl operator*(UInt128Impl lhs, UInt128Impl rhs) { > > Not introduced by you but { belongs on next line. Talked with Mark offline. We left this since this file is imported one from abseil-cpp, and we would like to keep as the same as the original to make future update easier.
EWS
Comment 6 2021-10-25 17:16:18 PDT
Committed r284850 (243527@main): <https://commits.webkit.org/243527@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442421 [details].
Radar WebKit Bug Importer
Comment 7 2021-10-25 17:17:18 PDT
<rdar://problem/84639097>
Note You need to log in before you can comment on or make changes to this bug.