Bug 232247

Summary: [macOS][GPUP] Remove sandbox write access to files
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch none

Description Per Arne Vollan 2021-10-25 10:29:53 PDT
Based on telemetry, remove sandbox write access to files in the GPU process on macOS.
Comment 1 Radar WebKit Bug Importer 2021-10-25 10:30:33 PDT
<rdar://problem/84620023>
Comment 2 Per Arne Vollan 2021-10-25 10:31:57 PDT
Created attachment 442382 [details]
Patch
Comment 3 Brent Fulgham 2021-11-10 14:34:37 PST
Comment on attachment 442382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442382&action=review

r=me

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-107
> -        (vnode-type REGULAR-FILE)))

Are we confident this isn't needed to support crash reporting?
Comment 4 Per Arne Vollan 2021-11-12 07:27:36 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 442382 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442382&action=review
> 
> r=me
> 
> > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-107
> > -        (vnode-type REGULAR-FILE)))
> 
> Are we confident this isn't needed to support crash reporting?

I have tried terminating the WebContent process, which also has this rule, and no files are created in '/cores', so I believe we can remove this access.

Thanks for reviewing!
Comment 5 EWS 2021-11-12 07:29:01 PST
Tools/Scripts/svn-apply failed to apply attachment 442382 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Per Arne Vollan 2021-11-12 08:10:12 PST
Created attachment 444069 [details]
Patch
Comment 7 EWS 2021-11-12 08:39:07 PST
Committed r285723 (244182@main): <https://commits.webkit.org/244182@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444069 [details].