Bug 232240

Summary:

Fix CSS serialization affecting grid-auto-flow

Product:

WebKit

Reporter:

zsun

Component:

CSS

Assignee:

zsun

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, rego, svillar, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zsun 2021-10-25 06:59:19 PDT

We need to fix the serialization issue of grid-auto-flow where the word 'row' was being included necessarily.

The following WPT tests have been affected - 

css/css-grid/grid-layout-properties.html
css/css-grid/parsing/grid-auto-flow-computed.html
css/css-grid/parsing/grid-auto-flow-valid.html

Comment 1 zsun 2021-10-25 07:11:00 PDT

Created attachment 442366 [details]
Patch

Comment 2 zsun 2021-10-25 12:13:22 PDT

Created attachment 442395 [details]
Patch

Comment 3 EWS Watchlist 2021-10-25 12:14:41 PDT

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Comment 4 EWS 2021-10-26 10:08:17 PDT

Committed r284876 (243553@main): <https://commits.webkit.org/243553@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442395 [details].

Comment 5 Radar WebKit Bug Importer 2021-10-26 10:09:23 PDT

<rdar://problem/84668897>