Bug 232238

Summary: [CSS Cascade Layers] Media queries should be able to affect layer order
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220779    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2021-10-25 06:39:30 PDT
We may get layer order wrong in case @layer rules are used within dynamic media queries.
Comment 1 Antti Koivisto 2021-10-25 06:58:26 PDT
Created attachment 442365 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-25 09:58:47 PDT
Comment on attachment 442365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442365&action=review

> Source/WebCore/ChangeLog:21
> +        Ddisable dynamic media query evaluation for now when we see a @layer rule within a media query.

Ddisable
Comment 3 Antti Koivisto 2021-10-25 12:09:49 PDT
Created attachment 442393 [details]
Patch
Comment 4 EWS 2021-10-25 12:45:42 PDT
Tools/Scripts/svn-apply failed to apply attachment 442393 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 5 Antti Koivisto 2021-10-25 22:54:11 PDT
Created attachment 442465 [details]
Patch
Comment 6 EWS 2021-10-26 00:21:45 PDT
Cases like found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 7 Antti Koivisto 2021-10-26 00:24:49 PDT
Created attachment 442469 [details]
Patch
Comment 8 EWS 2021-10-26 01:30:55 PDT
Committed r284859 (243536@main): <https://commits.webkit.org/243536@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442469 [details].
Comment 9 Radar WebKit Bug Importer 2021-10-26 01:31:25 PDT
<rdar://problem/84653129>