Bug 232223

Summary: WTR / DRT should rely on SecurityOrigin::isLocalHostOrLoopbackIPAddress()
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: Tools / TestsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED WONTFIX    
Severity: Enhancement CC: clopez, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236049
https://bugs.webkit.org/show_bug.cgi?id=127676
https://bugs.webkit.org/show_bug.cgi?id=160504
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch ews-feeder: commit-queue-

Alexey Shvayka
Reported 2021-10-24 16:58:09 PDT
WTR / DTR should rely on SecurityOrigin::isLocalHostOrLoopbackIPAddress()
Attachments
Patch (37.34 KB, patch)
2021-10-24 16:59 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (37.43 KB, patch)
2021-10-24 17:05 PDT, Alexey Shvayka 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (50.55 KB, patch)
2021-10-24 17:30 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (593.19 KB, patch)
2021-10-24 21:55 PDT, Alexey Shvayka 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-10-24 16:59:13 PDT
Created attachment 442331 [details] Patch
Alexey Shvayka
Comment 2 2021-10-24 17:05:55 PDT
Created attachment 442332 [details] Patch
EWS Watchlist
Comment 3 2021-10-24 17:06:56 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Alexey Shvayka
Comment 4 2021-10-24 17:30:27 PDT
Created attachment 442333 [details] Patch
Alexey Shvayka
Comment 5 2021-10-24 21:55:05 PDT
Created attachment 442337 [details] Patch
Geoffrey Garen
Comment 6 2021-10-27 10:50:05 PDT
Comment on attachment 442337 [details] Patch Seems like the right approach. EWS is still failing.
Radar WebKit Bug Importer
Comment 7 2021-10-31 16:59:16 PDT
<rdar://problem/84862800>
Alexey Shvayka
Comment 8 2022-08-05 18:29:50 PDT
Closing this in favour of https://github.com/WebKit/WebKit/pull/2489, and also since my solution doesn't work on EWS.
Note You need to log in before you can comment on or make changes to this bug.