Bug 23222

Summary: Repainting is broken with transforms
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Testcase
none
Patch, LayoutTest changelog mitz: review+

Description Simon Fraser (smfr) 2009-01-09 17:35:40 PST
The attached testcase shows that repainting with a layoutDelta in effect is broken when an ancestor is transformed.
Comment 1 Simon Fraser (smfr) 2009-01-09 17:35:56 PST
Created attachment 26585 [details]
Testcase
Comment 2 Simon Fraser (smfr) 2009-01-10 17:57:02 PST
Actually I think the testcase is showing an issue with LayoutState, not layoutDelta.
Comment 3 Simon Fraser (smfr) 2009-01-10 18:29:46 PST
Created attachment 26595 [details]
Patch, LayoutTest changelog

I changed RenderBlock::layoutOnlyPositionedObjects() to use the same criteria as RenderBlock::layoutBlock() for disabling layoutState, because testing showed that layoutOnlyPositionedObjects() could be hit for a block with a reflection. I think this is the right thing to do.
Comment 4 Simon Fraser (smfr) 2009-01-10 18:48:14 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/repaint/transform-disable-layoutstate.html
	A	LayoutTests/platform/mac/fast/repaint/transform-disable-layoutstate-expected.checksum
	A	LayoutTests/platform/mac/fast/repaint/transform-disable-layoutstate-expected.png
	A	LayoutTests/platform/mac/fast/repaint/transform-disable-layoutstate-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderFlexibleBox.cpp
Committed r39781
Comment 5 Simon Fraser (smfr) 2009-01-10 23:12:46 PST
See also bug 23233.