Summary: | Repainting is broken with transforms | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hyatt, mitz | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2009-01-09 17:35:40 PST
Created attachment 26585 [details]
Testcase
Actually I think the testcase is showing an issue with LayoutState, not layoutDelta. Created attachment 26595 [details]
Patch, LayoutTest changelog
I changed RenderBlock::layoutOnlyPositionedObjects() to use the same criteria as RenderBlock::layoutBlock() for disabling layoutState, because testing showed that layoutOnlyPositionedObjects() could be hit for a block with a reflection. I think this is the right thing to do.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/repaint/transform-disable-layoutstate.html A LayoutTests/platform/mac/fast/repaint/transform-disable-layoutstate-expected.checksum A LayoutTests/platform/mac/fast/repaint/transform-disable-layoutstate-expected.png A LayoutTests/platform/mac/fast/repaint/transform-disable-layoutstate-expected.txt M WebCore/ChangeLog M WebCore/rendering/RenderBlock.cpp M WebCore/rendering/RenderFlexibleBox.cpp Committed r39781 |