Bug 232214

Summary: webkitpy: rename assertEquals/assertNotEquals
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232213    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Sam Sneddon [:gsnedders] 2021-10-24 04:50:32 PDT 
These have been deprecated for a while: https://docs.python.org/3.10/library/unittest.html#deprecated-aliases
Comment 1 Sam Sneddon [:gsnedders] 2021-10-24 05:05:05 PDT 
Created attachment 442306 [details]
Patch
Comment 2 Alexey Proskuryakov 2021-10-24 11:32:48 PDT 
Comment on attachment 442306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442306&action=review

> Source/WebKit/ChangeLog:11
> +        aliases assertEqual/assertEquals. These have long been deprecated, and

Is “assertEqual” meant to be “assertNotEquals” on this line?
Comment 3 Sam Sneddon [:gsnedders] 2021-10-25 03:34:00 PDT 
Created attachment 442356 [details]
Patch for landing
Comment 4 EWS 2021-10-25 04:07:27 PDT 
Committed r284775 (243484@main): <https://commits.webkit.org/243484@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442356 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-25 04:08:18 PDT 
<rdar://problem/84609161>