Summary: | Add an ImageDiff option to print out WPT-style pixel differences | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, darin, gsnedders, Hironori.Fujii, jbedard, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 232201 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2021-10-23 20:58:09 PDT
Created attachment 442291 [details]
Patch
Comment on attachment 442291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442291&action=review r=me even though this current version of the patch doesn’t apply yet > Tools/ImageDiff/ImageDiff.cpp:52 > +static int processImages(std::unique_ptr<PlatformImage>&& actualImage, std::unique_ptr<PlatformImage>&& baselineImage, float tolerance, bool printDifferance) There’s a spelling error here where difference has an a instead of an E. I recommend searching for “ifferance” and fixing them all. > Tools/ImageDiff/ImageDiff.cpp:136 > + " -d, --difference print WTP-style maxDifference and totalPixels data\n" \ I think we mean WPT not WTP |