| Summary: | Add support for fast-cq mode to webkit-patch land-safely command | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, glenn, jbedard, ryanhaddad, webkit-bug-importer, wilander | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Other | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=224286 https://bugs.webkit.org/show_bug.cgi?id=223954 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
Aakash Jain
2021-10-23 04:59:25 PDT
fast-cq support for webkit-patch land-safely command was requested in https://lists.webkit.org/pipermail/webkit-dev/2021-October/032019.html Created attachment 442257 [details]
Patch
Created attachment 442258 [details]
Patch
Thanks! This’ll be an excellent enhancement. Someone else should review the patch but it wasn’t clear to me that it updates the help documentation of webkit-patch. Does it? Maybe that’s generated somehow. Help documentation is updated automatically.
e.g.:
[~]$ webkit-patch help land-safely
land-safely [options] [BUGID] Land the current diff via the commit-queue
land-safely updates the ChangeLog with the reviewer listed
in bugs.webkit.org for BUGID (or the bug ID detected from the ChangeLog).
The command then uploads the current diff to the bug and marks it for
commit by the commit-queue.
Options:
--architecture=ARCHITECTURE
Target architecture
--check-oops Check there are no OOPS left in change log
--fast-cq, --fast-commit-queue, --fastcq
Enable fast-commit-queue mode for this patch, that
skips building and testing.
...
Created attachment 442368 [details]
[fast-cq] Patch for landing
Committed r284783 (243492@main): <https://commits.webkit.org/243492@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442368 [details]. Landed this with following command: webkit-patch land-safely --fast-cq |