Bug 232196

Summary: Add support for fast-cq mode to webkit-patch land-safely command
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, glenn, jbedard, ryanhaddad, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224286
https://bugs.webkit.org/show_bug.cgi?id=223954
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq] Patch for landing none

Aakash Jain
Reported 2021-10-23 04:59:25 PDT
We added fast-cq mode support to webkit-patch upload command in 236308@main. We should also add support for it in webkit-patch land-safely command.
Attachments
Patch (2.20 KB, patch)
2021-10-23 05:08 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (3.82 KB, patch)
2021-10-23 05:22 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (3.81 KB, patch)
2021-10-25 07:34 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-10-23 05:01:32 PDT
fast-cq support for webkit-patch land-safely command was requested in https://lists.webkit.org/pipermail/webkit-dev/2021-October/032019.html
Aakash Jain
Comment 2 2021-10-23 05:08:22 PDT
Created attachment 442257 [details] Patch
Aakash Jain
Comment 3 2021-10-23 05:22:54 PDT
Created attachment 442258 [details] Patch
John Wilander
Comment 4 2021-10-23 07:40:17 PDT
Thanks! This’ll be an excellent enhancement. Someone else should review the patch but it wasn’t clear to me that it updates the help documentation of webkit-patch. Does it? Maybe that’s generated somehow.
Aakash Jain
Comment 5 2021-10-25 05:21:23 PDT
Help documentation is updated automatically. e.g.: [~]$ webkit-patch help land-safely land-safely [options] [BUGID] Land the current diff via the commit-queue land-safely updates the ChangeLog with the reviewer listed in bugs.webkit.org for BUGID (or the bug ID detected from the ChangeLog). The command then uploads the current diff to the bug and marks it for commit by the commit-queue. Options: --architecture=ARCHITECTURE Target architecture --check-oops Check there are no OOPS left in change log --fast-cq, --fast-commit-queue, --fastcq Enable fast-commit-queue mode for this patch, that skips building and testing. ...
Aakash Jain
Comment 6 2021-10-25 07:34:43 PDT
Created attachment 442368 [details] [fast-cq] Patch for landing
EWS
Comment 7 2021-10-25 07:36:51 PDT
Committed r284783 (243492@main): <https://commits.webkit.org/243492@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442368 [details].
Aakash Jain
Comment 8 2021-10-25 07:37:13 PDT
Landed this with following command: webkit-patch land-safely --fast-cq
Radar WebKit Bug Importer
Comment 9 2021-10-25 07:37:45 PDT
<rdar://problem/84613190>
Note You need to log in before you can comment on or make changes to this bug.