| Summary: | [iOS] AVAssetResourceLoadingRequest.request does not include a Range: header on iOS 15. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
| Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, adamjamesstevens, calvaris, cdumez, changseok, darin, dustin.kerstein, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, japhet, philipj, sergio, simon.fraser, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=232076 https://bugs.webkit.org/show_bug.cgi?id=233836 |
||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jer Noble
2021-10-22 21:25:06 PDT
Created attachment 442252 [details]
Patch
Comment on attachment 442252 [details]
Patch
I don’t see any tests or expected test results changing here. Can we create a regression test for this?
(In reply to Darin Adler from comment #3) > Comment on attachment 442252 [details] > Patch > > I don’t see any tests or expected test results changing here. Can we create > a regression test for this? Hm. I was tempted to say no, but perhaps there's some inspector integration that we could use to verify the headers on a Blob request? I'll check. (In reply to Jer Noble from comment #4) > (In reply to Darin Adler from comment #3) > > Comment on attachment 442252 [details] > > Patch > > > > I don’t see any tests or expected test results changing here. Can we create > > a regression test for this? > > Hm. I was tempted to say no, but perhaps there's some inspector integration > that we could use to verify the headers on a Blob request? I'll check. The inspector tests are apparently Mac-only at the moment. I'll add a test regardless, even though it won't (can't) verify this particular behavior; once Inspector tests can cover iOS, it'll start working. Is this related to developer originated bug 232076 in some way? Or to bug 232174. (In reply to Alexey Proskuryakov from comment #6) > Is this related to developer originated bug 232076 in some way? Yes, this patch is a workaround for the system behavior discovered while investigating bug #232076. Created attachment 442630 [details]
Patch for landing
Created attachment 443004 [details]
Patch for landing
Created attachment 443098 [details]
Patch for landing
Created attachment 443112 [details]
Patch for landing
Committed r285210 (243836@main): <https://commits.webkit.org/243836@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443112 [details]. I know this is unlikely to be known / allowed to be divulged, but does anyone at Apple happen to know if this fix will find its way into the upcoming iOS / iPadOS 15.2 release? It would be awesome if it could be prioritized given the lag we'll see until the majority of compatible devices get upgraded to that upcoming version. Thanks! Hey @Jer. When you say landed, would you mind explaining what that means? When can we expect the fix to make it the public? Thanks! Landed means it’s committed in the WebKit open source project. Apple people here don’t get to announce ahead of time when the changes show up in iOS and macOS. I understand how useful it would be to know that! Yeah that makes sense :) Is there a way we can test it prior to release, or perhaps provide you with a test URL that doesn’t work on the current iOS version? Just gave this a quick spin in the official iPadOS 15.2 release and it doesn't look like it includes this fix. Crossing my fingers in hope that the next update does. I'm not sure how many production sites rely on blob + video, but for those that do, this is a pretty severe breaking bug, and one that doesn't have a really solid workaround for all use-cases. Quick update - Tested on iPadOS 15.3 Beta (19D5026g) and I am able to still replicate this bug. Is there a possibility of having a timeline on this reaching a point release? It's a critical issue for us. Thank you! Just another quick update - The final version iPadOS 15.3 does not have this fix. In case Darin was unclear, there is not a possibility of having a timeline on this reaching a point release. Apple does not comment on future releases. |