Bug 232188

Summary: REGRESSION: [Win] fast/ruby/generated-before-counter-doesnt-crash.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Ryan Haddad <ryanhaddad>
Status: REOPENED ---    
Severity: Normal CC: koivisto, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232876
Attachments:
Description Flags
Update TestExpectations none

Description Ryan Haddad 2021-10-22 17:41:52 PDT 
fast/ruby/generated-before-counter-doesnt-crash.html is a flaky failure on Windows bots 

--- /home/buildbot/worker/Windows-EWS/build/layout-test-results/fast/ruby/generated-before-counter-doesnt-crash-expected.txt
+++ /home/buildbot/worker/Windows-EWS/build/layout-test-results/fast/ruby/generated-before-counter-doesnt-crash-actual.txt
@@ -1,2 +1,4 @@
+Blocked access to external URL http://xx/
+Blocked access to external URL http://xx/
 Blocked access to external URL http://xx/
 This test passes if it doesn't crash.

https://results.webkit.org/?suite=layout-tests&test=fast/ruby/generated-before-counter-doesnt-crash.html
Comment 1 Ryan Haddad 2021-10-22 17:47:25 PDT 
Created attachment 442232 [details]
Update TestExpectations
Comment 2 EWS 2021-10-22 17:49:10 PDT 
Committed r284731 (243443@main): <https://commits.webkit.org/243443@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442232 [details].
Comment 3 Ryan Haddad 2021-10-22 17:50:00 PDT 
Reopening for investigation.
Comment 4 Radar WebKit Bug Importer 2021-10-29 17:42:17 PDT 
<rdar://problem/84829734>
Comment 5 Antti Koivisto 2021-11-10 09:53:04 PST 
The test should be fixed to use file: URL which will stop it from outputting anything make it non-flaky. 

However it is currently sort of useful since it happens to reveal any problems in a cache used during style resolution (matched declaration cache). We should probably add an explicit test for that as part of fixing this test.