Bug 232186

Summary:

Bring up queues for Monterey

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

Tools / Tests

Assignee:

Ryan Haddad <ryanhaddad>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, jbedard, jlewis3, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
[fast-cq] Patch for landing	none
[fast-cq] Patch for landing	none

Description Ryan Haddad 2021-10-22 16:41:28 PDT

Bring up queues for Monterey

Comment 1 Radar WebKit Bug Importer 2021-10-22 16:41:42 PDT

<rdar://problem/84568508>

Comment 2 Ryan Haddad 2021-10-22 16:49:13 PDT

Created attachment 442225 [details]
Patch

Comment 3 Ryan Haddad 2021-10-22 16:50:09 PDT

Monterey won't be released until Monday, but I figured I may as well get the patch up.

Comment 4 Alexey Proskuryakov 2021-10-23 13:51:28 PDT

Comment on attachment 442225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442225&action=review

> Tools/CISupport/build-webkit-org/config.json:174
> +                    { "name": "Apple-Monterey-Release-WK2-WebGL-GPUProcess-Tests", "factory": "TestAllButJSCFactory", "builddir": "monterey-release-tests-wk2-webgl-gpuprocess",

Looks like we are moving this bot from Big Sur, not adding one for Monterey. Is this the right thing to do?

> Tools/CISupport/build-webkit-org/wkbuild.py:81
>          ("LayoutTests/platform/mac-bigsur", ["mac-bigsur"]),
> +        ("LayoutTests/platform/mac-monterey", ["mac-monterey"]),

This looks wrong, changes to Monterey expectations should trigger tests on all older OSes too. Same for Big Sur.

Comment 5 Ryan Haddad 2021-10-25 10:55:41 PDT

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 442225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442225&action=review
> 
> > Tools/CISupport/build-webkit-org/config.json:174
> > +                    { "name": "Apple-Monterey-Release-WK2-WebGL-GPUProcess-Tests", "factory": "TestAllButJSCFactory", "builddir": "monterey-release-tests-wk2-webgl-gpuprocess",
> 
> Looks like we are moving this bot from Big Sur, not adding one for Monterey.
> Is this the right thing to do?

No, it was not. I have updated the patch to leave it in place.

> 
> > Tools/CISupport/build-webkit-org/wkbuild.py:81
> >          ("LayoutTests/platform/mac-bigsur", ["mac-bigsur"]),
> > +        ("LayoutTests/platform/mac-monterey", ["mac-monterey"]),
> 
> This looks wrong, changes to Monterey expectations should trigger tests on
> all older OSes too. Same for Big Sur.

Good catch. Fixed for both Big Sur and Monterey.

Comment 6 Ryan Haddad 2021-10-25 11:05:24 PDT

Created attachment 442388 [details]
[fast-cq] Patch for landing

Comment 7 EWS 2021-10-25 11:06:56 PDT

Committed r284799 (243506@main): <https://commits.webkit.org/243506@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442388 [details].

Comment 8 Ryan Haddad 2021-11-05 13:30:36 PDT

Reopening for a follow-up fix.

Comment 9 Ryan Haddad 2021-11-05 13:30:52 PDT

Created attachment 443430 [details]
[fast-cq] Patch for landing

Comment 10 EWS 2021-11-05 13:32:56 PDT

Committed r285353 (243912@main): <https://commits.webkit.org/243912@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443430 [details].