Bug 232186

Summary: Bring up queues for Monterey
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, jbedard, jlewis3, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq] Patch for landing
none
[fast-cq] Patch for landing none

Ryan Haddad
Reported 2021-10-22 16:41:28 PDT
Bring up queues for Monterey
Attachments
Patch (46.17 KB, patch)
2021-10-22 16:49 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (45.18 KB, patch)
2021-10-25 11:05 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch for landing (2.68 KB, patch)
2021-11-05 13:30 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-22 16:41:42 PDT
<rdar://problem/84568508>
Ryan Haddad
Comment 2 2021-10-22 16:49:13 PDT
Created attachment 442225 [details] Patch
Ryan Haddad
Comment 3 2021-10-22 16:50:09 PDT
Monterey won't be released until Monday, but I figured I may as well get the patch up.
Alexey Proskuryakov
Comment 4 2021-10-23 13:51:28 PDT
Comment on attachment 442225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442225&action=review > Tools/CISupport/build-webkit-org/config.json:174 > + { "name": "Apple-Monterey-Release-WK2-WebGL-GPUProcess-Tests", "factory": "TestAllButJSCFactory", "builddir": "monterey-release-tests-wk2-webgl-gpuprocess", Looks like we are moving this bot from Big Sur, not adding one for Monterey. Is this the right thing to do? > Tools/CISupport/build-webkit-org/wkbuild.py:81 > ("LayoutTests/platform/mac-bigsur", ["mac-bigsur"]), > + ("LayoutTests/platform/mac-monterey", ["mac-monterey"]), This looks wrong, changes to Monterey expectations should trigger tests on all older OSes too. Same for Big Sur.
Ryan Haddad
Comment 5 2021-10-25 10:55:41 PDT
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 442225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442225&action=review > > > Tools/CISupport/build-webkit-org/config.json:174 > > + { "name": "Apple-Monterey-Release-WK2-WebGL-GPUProcess-Tests", "factory": "TestAllButJSCFactory", "builddir": "monterey-release-tests-wk2-webgl-gpuprocess", > > Looks like we are moving this bot from Big Sur, not adding one for Monterey. > Is this the right thing to do? No, it was not. I have updated the patch to leave it in place. > > > Tools/CISupport/build-webkit-org/wkbuild.py:81 > > ("LayoutTests/platform/mac-bigsur", ["mac-bigsur"]), > > + ("LayoutTests/platform/mac-monterey", ["mac-monterey"]), > > This looks wrong, changes to Monterey expectations should trigger tests on > all older OSes too. Same for Big Sur. Good catch. Fixed for both Big Sur and Monterey.
Ryan Haddad
Comment 6 2021-10-25 11:05:24 PDT
Created attachment 442388 [details] [fast-cq] Patch for landing
EWS
Comment 7 2021-10-25 11:06:56 PDT
Committed r284799 (243506@main): <https://commits.webkit.org/243506@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442388 [details].
Ryan Haddad
Comment 8 2021-11-05 13:30:36 PDT
Reopening for a follow-up fix.
Ryan Haddad
Comment 9 2021-11-05 13:30:52 PDT
Created attachment 443430 [details] [fast-cq] Patch for landing
EWS
Comment 10 2021-11-05 13:32:56 PDT
Committed r285353 (243912@main): <https://commits.webkit.org/243912@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443430 [details].
Note You need to log in before you can comment on or make changes to this bug.