Bug 232166

Summary:

[ iOS15 EWS ] TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequest tests are timing out

Product:

WebKit

Reporter:

Eric Hutchison <ehutchison>

Component:

New Bugs

Assignee:

Kate Cheney <katherine_cheney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, ehutchison, katherine_cheney, webkit-bot-watchers-bugzilla, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Eric Hutchison 2021-10-22 12:48:34 PDT

TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsNonAppInitiated
TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsAppInitiated

are timing out on iOS15 EWS.

History: https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsAppInitiated&test=TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsNonAppInitiated

Build: https://ews-build.webkit.org/#/builders/9/builds/57175

STDIO: https://ews-build.webkit.org/api/v2/logs/15245550/raw

Timeout
    TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsAppInitiated
        2021-10-22 06:20:37.016 TestWebKitAPI[5427:88588] Writing analzed variants.
    TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsNonAppInitiated
        2021-10-22 06:21:10.058 TestWebKitAPI[5441:88922] Writing analzed variants.

worker/0 TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsAppInitiated Timeout
2021-10-22 06:21:10.058 TestWebKitAPI[5441:88922] Writing analzed variants.
worker/0 TestWebKitAPI.AppPrivacyReport.LoadSimulatedRequestIsNonAppInitiated Timeout
2021-10-22 06:21:43.587 TestWebKitAPI[5453:89357] Writing analzed variants.

Will attempt repro locally.

Comment 1 Eric Hutchison 2021-10-22 13:19:22 PDT

Regression range is: https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=284506&stop_rev=284469&limit=100.

This may be related to changes made in: https://trac.webkit.org/changeset/284474/webkit

Comment 2 Radar WebKit Bug Importer 2021-10-22 13:19:33 PDT

<rdar://problem/84560948>

Comment 3 Ryan Haddad 2021-10-22 15:33:49 PDT

I have not yet been able to reproduce this locally, and trunk bots aren't hitting it either.

iOS EWS is consistently seeing these tests time out, so I've disabled them temporarily with  r284721.

Comment 4 Alex Christensen 2021-10-29 09:48:46 PDT

Re-enabled in r285034
Will watch bots to verify that everything is ok.

Comment 5 Eric Hutchison 2021-10-29 16:14:30 PDT

Timeout started again as soon as tests were re-enabled.

Comment 6 Alex Christensen 2021-10-29 16:22:12 PDT

https://ews-build.webkit.org/#/builders/9
Sure enough

Comment 7 Alex Christensen 2021-10-29 16:24:54 PDT

Re-disabled in r285060

Comment 8 Kate Cheney 2021-10-29 16:39:43 PDT

Created attachment 442880 [details]
Patch

Comment 9 Kate Cheney 2021-10-29 16:40:07 PDT

(In reply to Kate Cheney from comment #8)
> Created attachment 442880 [details]
> Patch

some experimental logging to see if EWS will tell us where it is timing out.

Comment 10 Kate Cheney 2021-11-01 16:24:56 PDT

Created attachment 443032 [details]
Patch

Comment 11 Kate Cheney 2021-11-02 09:04:07 PDT

Created attachment 443096 [details]
Patch

Comment 12 Kate Cheney 2021-11-02 12:43:55 PDT

Created attachment 443123 [details]
Patch

Comment 13 Kate Cheney 2021-11-03 11:36:06 PDT

Created attachment 443218 [details]
Patch

Comment 14 Kate Cheney 2021-11-04 17:17:43 PDT

Created attachment 443359 [details]
Patch

Comment 15 Kate Cheney 2021-11-04 17:18:06 PDT

(In reply to Kate Cheney from comment #14)
> Created attachment 443359 [details]
> Patch

Test to see if the order of test is causing it to fail, I moved it to a new location.

Comment 16 Kate Cheney 2021-11-05 11:04:27 PDT

Created attachment 443419 [details]
Patch

Comment 17 Kate Cheney 2021-11-05 15:30:03 PDT

(In reply to Kate Cheney from comment #16)
> Created attachment 443419 [details]
> Patch

Ok, changing the HTML seems to have fixed it, so something about loading the img src in the HTML seems to be causing a timeout.

Comment 18 Chris Dumez 2021-11-05 15:33:18 PDT

Comment on attachment 443419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443419&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:713
> +  //  NSString *HTML = @"<html><head></head><body><img src='https://apple.com/'></img></body></html>";

Is this really trying to connect to https://apple.com/ on the Web? If so, that not OK. Tests should not connect to the internet.

Comment 19 Kate Cheney 2021-11-05 16:30:37 PDT

Created attachment 443456 [details]
Patch

Comment 20 Kate Cheney 2021-11-05 16:32:34 PDT

Talked with Chris offline, hopefully using 127.0.0.1 and about:blank will fix the issue if potentially this is caused by bad internet connection or firewall.

Comment 21 Kate Cheney 2021-11-05 16:37:24 PDT

Created attachment 443457 [details]
Patch

Comment 22 Kate Cheney 2021-11-08 06:50:59 PST

Created attachment 443541 [details]
Patch

Comment 23 Alex Christensen 2021-11-08 09:29:55 PST

Comment on attachment 443541 [details]
Patch

wow

Comment 24 EWS 2021-11-08 10:05:29 PST

Committed r285411 (243968@main): <https://commits.webkit.org/243968@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443541 [details].