Bug 232158

Summary:

New test: [ iOS15 EWS ] TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides flaky fails on EWS

Product:

WebKit

Reporter:

Eric Hutchison <ehutchison>

Component:

CSS

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ehutchison, hi, megan_gardner, simon.fraser, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=219287

Bug Depends on:

219287

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Eric Hutchison 2021-10-22 10:42:49 PDT

TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides

is a flaky failure on iOS15 EWS>

History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides

Build: https://ews-build.webkit.org/#/builders/9/builds/57170

Results: STDIO: https://ews-build.webkit.org/api/v2/logs/15243827/raw

Failed
    TestWebKitAPI.CSSViewportUnits.SameUnobscuredSizeOverrides
        2021-10-22 04:57:37.702 TestWebKitAPI[25368:305875] Writing analzed variants.
        
        /Volumes/Data/worker/iOS-15-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:128
        Expected equality of these values:
          innerHeight
            Which is: 426
          getElementHeight(webView.get(), @"dvh")
            Which is: 500
        
        
        /Volumes/Data/worker/iOS-15-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:130
        Expected equality of these values:
          innerHeight
            Which is: 426
          getElementHeight(webView.get(), @"dvmax")
            Which is: 500
        
At this point, there are no failures on dashboard.

Will attempt reproduction locally.

Comment 1 Radar WebKit Bug Importer 2021-10-22 10:43:21 PDT

<rdar://problem/84555218>

Comment 2 Ryan Haddad 2021-10-22 15:25:31 PDT

The test was added with https://commits.webkit.org/243349@main, Devin is investigating.

It reproduces trivially when run locally with a few iterations.

Comment 3 Devin Rousso 2021-10-22 16:27:56 PDT

Created attachment 442217 [details]
Patch

Comment 4 Eric Hutchison 2021-10-26 09:44:11 PDT

TestWebKitAPI.CSSViewportUnits.DifferentUnobscuredSizeOverrides

has failed twice on iOS15 EWS API queue: 

https://ews-build.webkit.org/#/builders/9/builds/57383
https://ews-build.webkit.org/#/builders/9/builds/57266

STDIO: https://ews-build.webkit.org/api/v2/logs/15331160/raw

Failed
    TestWebKitAPI.CSSViewportUnits.DifferentUnobscuredSizeOverrides
        2021-10-26 00:18:37.292 TestWebKitAPI[25825:302080] Writing analzed variants.
        
        /Volumes/Data/worker/iOS-15-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:160
        Expected equality of these values:
          innerHeight
            Which is: 280
          getElementHeight(webVie

Comment 5 EWS 2021-11-01 12:23:00 PDT

Committed r285120 (243761@main): <https://commits.webkit.org/243761@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442217 [details].