Bug 232132

Summary: Remove unneeded Heap::m_vm.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
[fast-cq] proposed patch. none

Mark Lam
Reported 2021-10-21 22:01:33 PDT
Heap::vm() already computes the associated VM& using offset math. This entails subtracting a constant to Heap's this pointer, which is faster than loading from a field.
Attachments
proposed patch. (15.47 KB, patch)
2021-10-21 22:07 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
[fast-cq] proposed patch. (15.47 KB, patch)
2021-10-21 22:09 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-10-21 22:07:30 PDT
Created attachment 442119 [details] proposed patch.
Mark Lam
Comment 2 2021-10-21 22:09:42 PDT
Created attachment 442121 [details] [fast-cq] proposed patch.
Yusuke Suzuki
Comment 3 2021-10-21 22:13:08 PDT
Comment on attachment 442121 [details] [fast-cq] proposed patch. r=me
Mark Lam
Comment 4 2021-10-22 00:18:11 PDT
Comment on attachment 442121 [details] [fast-cq] proposed patch. Thanks for the review. Landing now.
EWS
Comment 5 2021-10-22 00:20:01 PDT
Committed r284668 (243388@main): <https://commits.webkit.org/243388@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442121 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-22 00:21:16 PDT
<rdar://problem/84538981>
Note You need to log in before you can comment on or make changes to this bug.