Bug 232132

Summary: Remove unneeded Heap::m_vm.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
[fast-cq] proposed patch. none

Description Mark Lam 2021-10-21 22:01:33 PDT 
Heap::vm() already computes the associated VM& using offset math.  This entails subtracting a constant to Heap's this pointer, which is faster than loading from a field.
Comment 1 Mark Lam 2021-10-21 22:07:30 PDT 
Created attachment 442119 [details]
proposed patch.
Comment 2 Mark Lam 2021-10-21 22:09:42 PDT 
Created attachment 442121 [details]
[fast-cq] proposed patch.
Comment 3 Yusuke Suzuki 2021-10-21 22:13:08 PDT 
Comment on attachment 442121 [details]
[fast-cq] proposed patch.

r=me
Comment 4 Mark Lam 2021-10-22 00:18:11 PDT 
Comment on attachment 442121 [details]
[fast-cq] proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2021-10-22 00:20:01 PDT 
Committed r284668 (243388@main): <https://commits.webkit.org/243388@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442121 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-22 00:21:16 PDT 
<rdar://problem/84538981>