Bug 232128
Summary: | Make transform a proper presentational attribute | ||
---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | heycam, karlcow, maggotfish, nmouchtaris, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann |
Priority: | P2 | Keywords: | InRadar |
Version: | Safari Technology Preview | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=263712 |
Simon Fraser (smfr)
Our SVG code currently does not treat `transform` as a presentational attribute. `transform-origin` is partially done (see the FIXME in createAttributeNameToCSSPropertyIDMap()). This all needs cleaning up.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Cameron McCormack (:heycam)
One tricky thing will be to make SVGTransformableElement.transform.{baseVal,animVal} do the right thing.
https://drafts.csswg.org/css-transforms-1/#transform-attribute-dom
Radar WebKit Bug Importer
<rdar://problem/84790424>
Nikolas Zimmermann
Good catch Karl. Indeed this is the „lazy SVG attribute synchronization“ that apparently exposes this bug. We probably fail to unmap properly..
Nikolas Zimmermann
Oops ignore the last comment, wrong bug report.
Notes that I tried this two years ago, but it was really hard to beat the speed of SVGTransformList parsing - even when adding multiple of fast paths for certain transformations as CSSParserFastPaths.
But we should repeat the experiment.
The only thing missing is rotation center support for rotate().
If there is interest, I can look up my code from a while ago