Bug 232124 – video appears blank with only audio playing if video element isn't appended to the dom tree

• Component: Media
• Status: RESOLVED FIXED

[Jean-Yves Avenard [:jya]]

If you do on iOS:

    let parent = document.getElementById("videoContainer");
    let ve = document.createElement("video");
    ve.src = "https://devstreaming-cdn.apple.com/videos/wwdc/2021/10073/7/53148F9F-7E28-46AA-AD05-CC2ABEC68EDC/downloads/wwdc2021-10073_sd.mp4";
    ve.play();

https://codepen.io/iffwang/pen/powQodO

Then only the audio will play, the image stays black.

[Jean-Yves Avenard [:jya]]

rdar://83438282

[Jean-Yves Avenard [:jya]]

Created attachment 442153 [details]
Patch

[Eric Carlson]

Comment on attachment 442153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442153&action=review

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:483
> +    if (RefPtr player = m_player.get()) {

Is this ref count churn helpful, wouldn't `auto* player = m_player.get()` work?

[Jean-Yves Avenard [:jya]]

Created attachment 442246 [details]
Patch

apply comment

[EWS]

Committed r284741 (243450@main): <https://commits.webkit.org/243450@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442246 [details].