Summary: | video appears blank with only audio playing if video element isn't appended to the dom tree | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||
Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=232125 https://bugs.webkit.org/show_bug.cgi?id=232193 |
||||||||
Attachments: |
|
Description
Jean-Yves Avenard [:jya]
2021-10-21 18:07:40 PDT
Created attachment 442153 [details]
Patch
Comment on attachment 442153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442153&action=review > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:483 > + if (RefPtr player = m_player.get()) { Is this ref count churn helpful, wouldn't `auto* player = m_player.get()` work? Created attachment 442246 [details]
Patch
apply comment
Committed r284741 (243450@main): <https://commits.webkit.org/243450@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442246 [details]. |