Summary: | Coding style for inner namespaces is should be simplified to not indented | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||
Component: | Tools / Tests | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, koivisto, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Kimmo Kinnunen
2021-10-21 03:08:51 PDT
Created attachment 442004 [details]
Patch
Comment on attachment 442004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442004&action=review > Websites/webkit.org/ChangeLog:3 > + Coding style for inner namespaces is should be simplified to not indented We normally discuss coding style changes on WebKit-dev mailing list, would you mind sending the proposal there? This seemed more like a documentation bug fix to match the actual coding style but it is true that it appears to not have been discussed on webkit-dev. It might be worth adding an example with C++17 nested namespace syntax, like in https://bugs.webkit.org/show_bug.cgi?id=232162 Created attachment 443779 [details]
Patch
Created attachment 443807 [details]
Patch
Committed r285601 (244105@main): <https://commits.webkit.org/244105@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443807 [details]. |