Summary: | [ iOS15 EWS ] RELEASE_ASSERT(isRunningTest(WebCore::applicationBundleIdentifier())) on http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html (flaky) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Hutchison <ehutchison> | ||||||
Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, ap, ehutchison, katherine_cheney, webkit-bot-watchers-bugzilla, webkit-bug-importer, wilander | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=232108 https://bugs.webkit.org/show_bug.cgi?id=232115 https://bugs.webkit.org/show_bug.cgi?id=232102 https://bugs.webkit.org/show_bug.cgi?id=232278 https://bugs.webkit.org/show_bug.cgi?id=231255 https://bugs.webkit.org/show_bug.cgi?id=231431 https://bugs.webkit.org/show_bug.cgi?id=231748 |
||||||||
Attachments: |
|
Description
Eric Hutchison
2021-10-20 14:36:13 PDT
Updated test expectations at https://trac.webkit.org/changeset/284572/webkit I think this is hitting the following assert: RELEASE_ASSERT(isRunningTest(WebCore::applicationBundleIdentifier())) (In reply to Ryan Haddad from comment #3) > I think this is hitting the following assert: > > RELEASE_ASSERT(isRunningTest(WebCore::applicationBundleIdentifier())) It is. The weird thing is why the assertion fails. It checks that the app calling the test API is the test runner. I intend to land logging of what the diff/fail is and use that as the basis for a fix. Checking the history link, I don't see any instances of this crashing on trunk. Maybe this issue is test order dependent. Adding logging in https://bugs.webkit.org/show_bug.cgi?id=232108. Reverted test expectation in https://bugs.webkit.org/show_bug.cgi?id=232115. Is is a post-logging crash: https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/r442369-393/results.html `isRunningTest() returned false. appBundleID is inAppBrowserPrivacyTestIdentifier.` (In reply to Ryan Haddad from comment #8) > Is is a post-logging crash: > https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/ > r442369-393/results.html > > `isRunningTest() returned false. appBundleID is > inAppBrowserPrivacyTestIdentifier.` Great! Well, not great but the logging payed off. I'll go check what's running with that app bundle ID and devise a fix. Thanks for the ping. (In reply to John Wilander from comment #9) > (In reply to Ryan Haddad from comment #8) > > Is is a post-logging crash: > > https://ews-build.s3-us-west-2.amazonaws.com/iOS-15-Simulator-WK2-Tests-EWS/ > > r442369-393/results.html > > > > `isRunningTest() returned false. appBundleID is > > inAppBrowserPrivacyTestIdentifier.` > > Great! Well, not great but the logging payed off. I'll go check what's > running with that app bundle ID and devise a fix. Thanks for the ping. It's this code: static void initializeInAppBrowserPrivacyTestSettings() { WTF::initializeMainThread(); WebCore::clearApplicationBundleIdentifierTestingOverride(); WebCore::setApplicationBundleIdentifier("inAppBrowserPrivacyTestIdentifier"); } I've reached out to Kate to ask about it. Seems like there may be a reset of that identifier missing. (In reply to John Wilander from comment #10) > I've reached out to Kate to ask about it. Seems like there may be a reset of > that identifier missing. Fix coming in https://bugs.webkit.org/show_bug.cgi?id=232278. Created attachment 442438 [details]
[fast-cq] Patch for landing
Committed r284848 (243525@main): <https://commits.webkit.org/243525@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442438 [details]. We may need another test fix for layout test that use <!-- webkit-test-runner [ enableInAppBrowserPrivacy=true applicationBundleIdentifier=inAppBrowserPrivacyTestIdentifier isAppBoundWebView=true ] --> _clearApplicationBundleIdentifierTestingOverride() needs to reset the ID in the network process. I've asked Kate to have a look. |