Bug 232008

Summary: fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html is failing
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2021-10-20 04:40:13 PDT 
selection rect computation issue
Comment 1 Antti Koivisto 2021-10-20 04:40:30 PDT Comment hidden (obsolete)
Comment 2 Antti Koivisto 2021-10-20 04:45:15 PDT 
Created attachment 441866 [details]
Patch
Comment 3 Antti Koivisto 2021-10-20 05:40:54 PDT 
Actually based on imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003.html our new behavior matches other browsers so lets just keep it and fix the failing test instead.
Comment 4 zalan 2021-10-20 06:10:34 PDT 
(In reply to Antti Koivisto from comment #3)
> Actually based on
> imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003.html
> our new behavior matches other browsers so lets just keep it and fix the
> failing test instead.
even better!
Comment 5 Antti Koivisto 2021-10-20 06:29:46 PDT 
Created attachment 441874 [details]
Patch
Comment 6 Antti Koivisto 2021-10-20 08:13:00 PDT 
Created attachment 441879 [details]
Patch
Comment 7 Wenson Hsieh 2021-10-20 08:15:00 PDT 
Comment on attachment 441879 [details]
Patch

select-rotated-transparent-image-overlay.html changes LGTM!
Comment 8 Antti Koivisto 2021-10-20 08:22:48 PDT Comment hidden (obsolete)
Comment 9 Antti Koivisto 2021-10-20 08:24:40 PDT 
Created attachment 441882 [details]
Patch
Comment 10 Antti Koivisto 2021-10-20 08:27:28 PDT 
uh rdar://84276269
Comment 11 Antti Koivisto 2021-10-20 08:28:10 PDT 
Created attachment 441883 [details]
Patch
Comment 12 Wenson Hsieh 2021-10-20 08:29:55 PDT 
*** Bug 231597 has been marked as a duplicate of this bug. ***
Comment 13 EWS 2021-10-20 10:14:17 PDT 
Committed r284542 (243284@main): <https://commits.webkit.org/243284@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441883 [details].