Bug 232008

Summary:

fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html is failing

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Antti Koivisto <koivisto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Antti Koivisto

Reported 2021-10-20 04:40:13 PDT

selection rect computation issue

Attachments
Patch (2.29 KB, patch) 2021-10-20 04:45 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch (4.50 KB, patch) 2021-10-20 06:29 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch (6.96 KB, patch) 2021-10-20 08:13 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch (6.96 KB, patch) 2021-10-20 08:24 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch (6.96 KB, patch) 2021-10-20 08:28 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2021-10-20 04:40:30 PDT Comment hidden (obsolete)

rdar://81573075

Antti Koivisto

Comment 2 2021-10-20 04:45:15 PDT

Created attachment 441866 [details] Patch

Antti Koivisto

Comment 3 2021-10-20 05:40:54 PDT

Actually based on imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003.html our new behavior matches other browsers so lets just keep it and fix the failing test instead.

alan

Comment 4 2021-10-20 06:10:34 PDT

(In reply to Antti Koivisto from comment #3) > Actually based on > imported/w3c/web-platform-tests/css/css-pseudo/highlight-painting-003.html > our new behavior matches other browsers so lets just keep it and fix the > failing test instead. even better!

Antti Koivisto

Comment 5 2021-10-20 06:29:46 PDT

Created attachment 441874 [details] Patch

Antti Koivisto

Comment 6 2021-10-20 08:13:00 PDT

Created attachment 441879 [details] Patch

Wenson Hsieh

Comment 7 2021-10-20 08:15:00 PDT

Comment on attachment 441879 [details] Patch select-rotated-transparent-image-overlay.html changes LGTM!

Antti Koivisto

Comment 8 2021-10-20 08:22:48 PDT Comment hidden (obsolete)

I mean rdar://84423425