Bug 232005

Summary:

[test262] test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-proto-from-caller-realm.js is failing

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pmates, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=230602

Attachments:

Description	Flags
Patch	none

Description Ryan Haddad 2021-10-19 23:34:34 PDT

The following test has been failing on test262 bots since https://trac.webkit.org/changeset/284435/webkit:

FAIL test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-proto-from-caller-realm.js (default)
Full Output:
Exception: ReferenceError: Can't find variable: r
global code@/Volumes/Data/worker/bigsur-applesilicon-release-tests-test262/build/JSTests/test262/test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-proto-from-caller-realm.js:38:11
FAIL test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-proto-from-caller-realm.js (strict mode)
Full Output:
Exception: ReferenceError: Can't find variable: r
global code@/Volumes/Data/worker/bigsur-applesilicon-release-tests-test262/build/JSTests/test262/test/built-ins/ShadowRealm/prototype/evaluate/wrapped-function-proto-from-caller-realm.js:39:11

https://build.webkit.org/#/builders/166/builds/3106

Comment 1 Radar WebKit Bug Importer 2021-10-19 23:35:13 PDT

<rdar://problem/84449774>

Comment 2 Phillip Mates 2021-10-20 02:05:01 PDT

Created attachment 441859 [details]
Patch

Comment 3 Phillip Mates 2021-10-20 02:07:28 PDT

This particular failure has subsequently been fixed in https://github.com/tc39/test262/pull/3251/files#diff-86f8c4c8961962ba7711ccf8bece8fc7ba4aeab5cf140ad137a1430b567ef073R38

Once fixed, the test still fails due to a bug in the current shadow realms implementation so I'm adding it to the expectations.yaml list of expected failures.

Given these changes, I also figured I'd include in the patch a full test262 update. This is my first time doing it, so please let me know if I missed a step

Comment 4 EWS 2021-10-23 17:47:29 PDT

Committed r284751 (243460@main): <https://commits.webkit.org/243460@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441859 [details].

Comment 5 Yusuke Suzuki 2021-10-26 11:40:38 PDT

This patch broke test262 bot. https://build.webkit.org/#/builders/8
expectations.yaml needs to be updated based on BigSur JSC.

Comment 6 Yusuke Suzuki 2021-10-26 11:57:52 PDT

Committed r284886 (243563@main): <https://commits.webkit.org/243563@main>