Bug 231996

Summary: *IsSane API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Saam Barati
Reported 2021-10-19 17:21:58 PDT
...
Attachments
Patch (16.99 KB, patch)
2021-10-20 21:17 PDT, Yusuke Suzuki 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-10-20 21:17:59 PDT
Created attachment 441981 [details] Patch
Mark Lam
Comment 2 2021-10-20 21:24:48 PDT
Comment on attachment 441981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441981&action=review > Source/JavaScriptCore/ChangeLog:3 > + *IsSain API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering drive by comment: Can you fix the typo in the title "isSain" => "isSane"? Same for bugzilla.
Yusuke Suzuki
Comment 3 2021-10-20 23:27:03 PDT
Comment on attachment 441981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441981&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + *IsSain API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering > > drive by comment: Can you fix the typo in the title "isSain" => "isSane"? Same for bugzilla. Thanks! Fixed.
Yusuke Suzuki
Comment 4 2021-10-20 23:28:14 PDT
Committed r284590 (243323@main): <https://commits.webkit.org/243323@main>
Radar WebKit Bug Importer
Comment 5 2021-10-20 23:29:16 PDT
<rdar://problem/84494690>
Saam Barati
Comment 6 2021-10-21 11:53:22 PDT
Comment on attachment 441981 [details] Patch Nice!
Note You need to log in before you can comment on or make changes to this bug.