| Summary: | *IsSane API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2021-10-19 17:21:58 PDT
Created attachment 441981 [details]
Patch
Comment on attachment 441981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441981&action=review > Source/JavaScriptCore/ChangeLog:3 > + *IsSain API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering drive by comment: Can you fix the typo in the title "isSain" => "isSane"? Same for bugzilla. Comment on attachment 441981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441981&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + *IsSain API's could take in the Structure's we're consulting, or they can be out parameters, so we don't rely on the CPU's memory ordering > > drive by comment: Can you fix the typo in the title "isSain" => "isSane"? Same for bugzilla. Thanks! Fixed. Committed r284590 (243323@main): <https://commits.webkit.org/243323@main> Comment on attachment 441981 [details]
Patch
Nice!
|