Bug 231979

Summary:

Eagerly resolve python3 path in Makefiles

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, ews-watchlist, jbedard, keith_miller, mark.lam, msaboff, ryanhaddad, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Description Alexey Proskuryakov 2021-10-19 12:55:40 PDT

There is an environment (cf. rdar://84212106) where running python3 is failing due to some low level issues that are yet to be understood.

It seems like these may be happening when resolving symlinks, so I want to try reducing the amount of resolving needed.

Comment 1 Alexey Proskuryakov 2021-10-19 12:58:13 PDT

Created attachment 441777 [details]
proposed patch

I believe that DerivedSources.make files are Xcode only at this point. EWS will tell for certain.

Comment 2 Alexey Proskuryakov 2021-10-19 15:51:42 PDT

Comment on attachment 441777 [details]
proposed patch

non-Xcode builds are green, cq+

Comment 3 EWS 2021-10-19 16:14:26 PDT

Committed r284507 (243253@main): <https://commits.webkit.org/243253@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441777 [details].

Comment 4 Radar WebKit Bug Importer 2021-10-19 17:22:05 PDT

<rdar://problem/84441156>