| Summary: | Address post-landing feedback to wasm exceptions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||||
| Component: | JavaScriptCore | Assignee: | Tadeu Zagallo <tzagallo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tadeu Zagallo
2021-10-19 12:02:03 PDT
Created attachment 441774 [details]
Patch
Comment on attachment 441774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441774&action=review r=me > Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:1176 > + // We have to materialize the arguments here since it might included constants or included => include > Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:1178 > + // in stack. The reason we don't call materializeConstantsAndLocals here is that in stack => in the stack Created attachment 441818 [details]
Patch for landing
Committed r284513 (243257@main): <https://commits.webkit.org/243257@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441818 [details]. |