Summary: | WebKit Objective-C classes should use weak delegates | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, kkinnunen, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=231919 https://bugs.webkit.org/show_bug.cgi?id=231927 |
||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2021-10-19 08:38:50 PDT
Created attachment 441730 [details]
Patch v1
Created attachment 441753 [details]
Patch v2 (fix typo in title)
Comment on attachment 441753 [details]
Patch v2 (fix typo in title)
r=me
Comment on attachment 441753 [details]
Patch v2 (fix typo in title)
Marking cq+ because I'm not sure if the ios bot will ever "fail" to allow a retry, and the ios-wk2 and api-ios bots are 8-24 hours behind.
In the "worst case", this patch would change a flakey crashing test to a flakey failing test, so only test expectations would need to be updated (and maybe a new bug filed for the non-crashing flakiness).
Committed r284558 (243300@main): <https://commits.webkit.org/243300@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441753 [details]. |